public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "roystgnr at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/110075] Bogus -Wdangling-reference
Date: Sat, 28 Oct 2023 21:26:46 +0000	[thread overview]
Message-ID: <bug-110075-4-6ySXRArkyB@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110075-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110075

Roy Stogner <roystgnr at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roystgnr at gmail dot com

--- Comment #2 from Roy Stogner <roystgnr at gmail dot com> ---
This case looks most similar to the one that my code triggered, which I
simplified to the following:

---

#include <map>

const double &
find_wrapper(const std::map<int, double> & map,
             const int & key)
{
  auto it = map.find(key);
  return it->second;
}


int main(void)
{
  std::map<int, double> testmap{{1,0.0}};
  const double & d = find_wrapper(testmap, 1);
  return int(d);
}

---

$ g++ -Wall -Wextra -Werror -o test.x test.C
test.C: In function ‘int main()’:
test.C:15:18: error: possibly dangling reference to a temporary
[-Werror=dangling-reference]
   15 |   const double & d = find_wrapper(testmap, 1);
      |                  ^
test.C:15:34: note: the temporary was destroyed at the end of the full
expression ‘find_wrapper(testmap, 1)’
   15 |   const double & d = find_wrapper(testmap, 1);
      |                      ~~~~~~~~~~~~^~~~~~~~~~~~
cc1plus: all warnings being treated as errors

---

If I change the parameter type to `const int key`, then the warning is not
triggered.  If I leave the parameter type as a reference but I pass in a
non-temporary variable "one" instead of "1", then the warning is not triggered.


Either or both of these cases might be a dup of bug 109642

  parent reply	other threads:[~2023-10-28 21:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 10:26 [Bug c++/110075] New: " pilarlatiesa at gmail dot com
2023-06-09 18:53 ` [Bug c++/110075] " pilarlatiesa at gmail dot com
2023-10-28 21:26 ` roystgnr at gmail dot com [this message]
2024-01-19 17:25 ` mpolacek at gcc dot gnu.org
2024-01-24  7:50 ` ostash at ostash dot kiev.ua
2024-01-24 15:51 ` mpolacek at gcc dot gnu.org
2024-01-28 16:21 ` ostash at ostash dot kiev.ua
2024-01-30 16:44 ` mpolacek at gcc dot gnu.org
2024-03-01 21:18 ` mpolacek at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110075-4-6ySXRArkyB@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).