From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 924993858C20; Mon, 26 Jun 2023 00:50:52 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 924993858C20
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1687740652;
	bh=9jm8HExj7RX7jxxNfADJxeYHmu5mfWKpTuO9euLC1wE=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=WoleCo6jdePSDGHRUU4ermEclOu2cmMjmxzdhpewfhZ9thCC65W/m10ocJnfTiNiF
	 Tx/oszaNH5PgEiFhBQX/2SXGcN2c/+rHahuLMVF1nQDHf964ewUlMLQXLkLsDvll6N
	 qp/fpnfmmtssDgWQgkx9qOM0bL9rE86qQ2wpOOVQ=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug d/110113] gdc -fpreview=dip1021 crash in d/dmd/root/aav.d:127
 dmd_aaGetRvalue from DsymbolTable::lookup(Identifier const*)
Date: Mon, 26 Jun 2023 00:50:52 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: d
X-Bugzilla-Version: 13.1.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ibuclaw at gdcproject dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-110113-4-Aoa1RQ3myw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-110113-4@http.gcc.gnu.org/bugzilla/>
References: <bug-110113-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110113

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Iain Buclaw
<ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:ae3a4cefd855512b10b833a56f275b701bacdb34

commit r13-7478-gae3a4cefd855512b10b833a56f275b701bacdb34
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Mon Jun 26 02:29:46 2023 +0200

    d: Fix crash in d/dmd/root/aav.d:127 dmd_aaGetRvalue from
DsymbolTable::lookup

    Backports patch from upstream dmd mainline for fixing PR110113.

    The data being Mem.xrealloc'd contains many Array(T) fields, some of
    which have self references in their data.ptr field thanks to the
    smallarray optimization used by Array.

    Naturally then, the memcpy from old GC data to new retains those self
    referenced addresses, and the GC marks the old data as "free". Some time
    later GC.malloc will return a pointer to said "free" data. So now we
    have two GC references to the same memory. One that is treating the data
    as an Array(VarDeclaration) in dmd.escape.escapeByStorage, and the other
    as an AA in the symtab of a dmd.dsymbol.ScopeDsymbol.

    Fix this memory corruption by not storing the data in a global variable
    for reuse.  If there are no more live references, the GC will free it.

            PR d/110113

    gcc/d/ChangeLog:

            * dmd/escape.d (checkMutableArguments): Always allocate new buf=
fer
for
            computing escapeBy.

    gcc/testsuite/ChangeLog:

            * gdc.test/compilable/test23978.d: New test.

    Reviewed-on: https://github.com/dlang/dmd/pull/15302=