public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/110170] Sub-optimal conditional jumps in conditional-swap with floating point
Date: Thu, 08 Jun 2023 19:40:10 +0000	[thread overview]
Message-ID: <bug-110170-4-VS5QvRR7Mf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110170-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110170

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86_64-linux-gnu

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note for aarch64, we do produce conditional moves but only when there is a
loop.

That is:
```
__attribute__((noinline))
void __cond_swap(double* __x, double* __y) {
  for(int i = 0; i < 100; i++, __x++, __y++) {
  double __r = (*__x < *__y);
  double __tmp = __r ? *__x : *__y;
  *__y = __r ? *__y : *__x;
  *__x = __tmp;
  }
}
```
Produces:
```
.L3:
        ldr     d31, [x0, x2]
        ldr     d30, [x1, x2]
        fcmpe   d31, d30
        fcsel   d29, d30, d31, mi
        fcsel   d31, d31, d30, mi
        str     d29, [x1, x2]
        str     d31, [x0, x2]
        add     x2, x2, 8
        cmp     x2, 800
        bne     .L3
```

Otherwise it will duplicate the return basic block (which is expected).

So this is a x86_64 specific issue.

  parent reply	other threads:[~2023-06-08 19:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 11:31 [Bug tree-optimization/110170] New: " antoshkka at gmail dot com
2023-06-08 11:34 ` [Bug tree-optimization/110170] " pinskia at gcc dot gnu.org
2023-06-08 11:57 ` [Bug target/110170] " antoshkka at gmail dot com
2023-06-08 13:32 ` pinskia at gcc dot gnu.org
2023-06-08 19:40 ` pinskia at gcc dot gnu.org [this message]
2023-06-09  5:38 ` crazylht at gmail dot com
2023-06-09  6:40 ` crazylht at gmail dot com
2023-06-09  7:01 ` crazylht at gmail dot com
2023-06-09  7:03 ` rguenth at gcc dot gnu.org
2023-06-12  2:17 ` crazylht at gmail dot com
2023-06-12  9:09 ` crazylht at gmail dot com
2023-07-04  5:46 ` crazylht at gmail dot com
2023-07-06  5:54 ` cvs-commit at gcc dot gnu.org
2023-07-10  1:06 ` cvs-commit at gcc dot gnu.org
2023-07-11  9:51 ` antoshkka at gmail dot com
2023-07-11 13:23 ` crazylht at gmail dot com
2023-07-11 13:57 ` cvs-commit at gcc dot gnu.org
2023-07-18 10:28 ` rguenth at gcc dot gnu.org
2023-07-18 10:33 ` crazylht at gmail dot com
2023-07-18 13:48 ` rguenth at gcc dot gnu.org
2023-07-21  8:18 ` rguenth at gcc dot gnu.org
2023-10-17  6:31 ` cvs-commit at gcc dot gnu.org
2023-10-17 11:14 ` cvs-commit at gcc dot gnu.org
2023-10-26  5:30 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110170-4-VS5QvRR7Mf@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).