public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/110248] ivopts could under-cost for some addressing modes on len_{load,store} Date: Wed, 14 Jun 2023 13:08:54 +0000 [thread overview] Message-ID: <bug-110248-4-gDJ2phU4LL@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-110248-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110248 --- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> --- (In reply to rsandifo@gcc.gnu.org from comment #5) > ivopts does have code to treat ifn pointer arguments specially, > see get_mem_type_for_internal_fn &co. But like Kewen says, > it's still only based on the mode. But the dump quoted says 'Type: POINTER ARGUMENT ADDRESS' which means that doesn't work as desired. That is, the use is classified wrongly and the above function only seems to be useful to get the mode of the memory access done by the internal function? USE_PTR_ADDRESS doesn't seem to be a very good match to capture constraints for a memory dereference? > Personally I'd prefer an internal_fn rather than a gimple* though. > It can be useful to test these things on a possible future statement, > not just on one that already exists. Well yes, passing down a gimple * looks like too generic here. Maybe use a code_helper so we can pass down MEM_REF for dereference context and nothing (ERROR_MARK_NODE?) for plain address use?
next prev parent reply other threads:[~2023-06-14 13:08 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-14 9:20 [Bug tree-optimization/110248] New: " linkw at gcc dot gnu.org 2023-06-14 11:45 ` [Bug tree-optimization/110248] " linkw at gcc dot gnu.org 2023-06-14 11:49 ` linkw at gcc dot gnu.org 2023-06-14 11:56 ` juzhe.zhong at rivai dot ai 2023-06-14 12:23 ` rguenth at gcc dot gnu.org 2023-06-14 12:55 ` rsandifo at gcc dot gnu.org 2023-06-14 13:08 ` rguenth at gcc dot gnu.org [this message] 2023-06-15 2:15 ` linkw at gcc dot gnu.org 2023-08-09 6:17 ` cvs-commit at gcc dot gnu.org 2023-08-09 6:17 ` cvs-commit at gcc dot gnu.org 2023-08-09 6:17 ` cvs-commit at gcc dot gnu.org 2023-08-10 2:03 ` linkw at gcc dot gnu.org 2023-08-14 8:09 ` jbglaw@lug-owl.de
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110248-4-gDJ2phU4LL@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).