From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 76FC4385772D; Wed, 19 Jul 2023 16:19:35 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76FC4385772D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1689783575;
	bh=h6fsy1+dQZjba1Wy3PqHOyqcukLp2Q/8dQ5leduxmHQ=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=gnxFeMS9Dq1fEaSRnlKmmwPS7u/LJ+aWqlJlZwo0dFwneqUXdWs79aSKAZ4vKYDly
	 KeHxz9PwAZCyG8dc1WqZo39oIR+DRmkYsECGFPiz3idKWi4pwumR8XfrZfahO+J/Df
	 DUrOYNeuVBfsdsaMcuSv0dHZfM0FyUZ/J1ekVWm4=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/110252] [14 Regression] Wrong code at -O2/3/s
 on x86_64-linux-gnu
Date: Wed, 19 Jul 2023 16:19:34 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: pinskia at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-110252-4-OPTVnkF5U6@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-110252-4@http.gcc.gnu.org/bugzilla/>
References: <bug-110252-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110252

--- Comment #18 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:8c79b49cd4fa742f7be739dd21fd2aa040cc1ba3

commit r14-2650-g8c79b49cd4fa742f7be739dd21fd2aa040cc1ba3
Author: Andrew Pinski <apinski@marvell.com>
Date:   Fri Jul 14 15:55:34 2023 -0700

    [PATCH] Fix tree-opt/110252: wrong code due to phiopt using flow sensit=
ive
info during match

    Match will query ranger via tree_nonzero_bits/get_nonzero_bits for 2 and
3rd
    operand of the COND_EXPR and phiopt tries to do create the COND_EXPR ev=
en
if we moving
    one statement. That one statement could have some flow sensitive
information on it
    based on the condition that is for the COND_EXPR but that might create
wrong code
    if the statement was moved out.

    This is similar to the previous version of the patch except now we use
    flow_sensitive_info_storage instead of manually doing the save/restore
    and also handle all defs on a gimple statement rather than just for lhs
    of the gimple statement. Oh and a few more testcases were added that
    was failing before.

    OK? Bootsrapped and tested on x86_64-linux-gnu with no regressions.

            PR tree-optimization/110252

    gcc/ChangeLog:

            * tree-ssa-phiopt.cc (class auto_flow_sensitive): New class.
            (auto_flow_sensitive::auto_flow_sensitive): New constructor.
            (auto_flow_sensitive::~auto_flow_sensitive): New deconstructor.
            (match_simplify_replacement): Temporarily
            remove the flow sensitive info on the two statements that might
            be moved.

    gcc/testsuite/ChangeLog:

            * gcc.dg/tree-ssa/phi-opt-25b.c: Updated as
            __builtin_parity loses the nonzerobits info.
            * gcc.c-torture/execute/pr110252-1.c: New test.
            * gcc.c-torture/execute/pr110252-2.c: New test.
            * gcc.c-torture/execute/pr110252-3.c: New test.
            * gcc.c-torture/execute/pr110252-4.c: New test.=