public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/110268] [14 Regression] arm MVE intrinsics support broken with LTO Date: Mon, 10 Jul 2023 14:15:40 +0000 [thread overview] Message-ID: <bug-110268-4-tGbemqnAVk@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-110268-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110268 --- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Christophe Lyon <clyon@gcc.gnu.org>: https://gcc.gnu.org/g:eca10aaa3954af3dab56eccc208c90273c2b1732 commit r14-2418-geca10aaa3954af3dab56eccc208c90273c2b1732 Author: Christophe Lyon <christophe.lyon@linaro.org> Date: Mon Jun 26 14:39:47 2023 +0000 arm: Fix MVE intrinsics support with LTO (PR target/110268) After the recent MVE intrinsics re-implementation, LTO stopped working because the intrinsics would no longer be defined. The main part of the patch is simple and similar to what we do for AArch64: - call handle_arm_mve_h() from arm_init_mve_builtins to declare the intrinsics when the compiler is in LTO mode - actually implement arm_builtin_decl for MVE. It was just a bit tricky to handle __ARM_MVE_PRESERVE_USER_NAMESPACE: its value in the user code cannot be guessed at LTO time, so we always have to assume that it was not defined. The led to a few fixes in the way we register MVE builtins as placeholders or not. Without this patch, we would just omit some versions of the inttrinsics when __ARM_MVE_PRESERVE_USER_NAMESPACE is true. In fact, like for the C/C++ placeholders, we need to always keep entries for all of them to ensure that we have a consistent numbering scheme. 2023-06-26 Christophe Lyon <christophe.lyon@linaro.org> PR target/110268 gcc/ * config/arm/arm-builtins.cc (arm_init_mve_builtins): Handle LTO. (arm_builtin_decl): Hahndle MVE builtins. * config/arm/arm-mve-builtins.cc (builtin_decl): New function. (add_unique_function): Fix handling of __ARM_MVE_PRESERVE_USER_NAMESPACE. (add_overloaded_function): Likewise. * config/arm/arm-protos.h (builtin_decl): New declaration. gcc/testsuite/ * gcc.target/arm/pr110268-1.c: New test. * gcc.target/arm/pr110268-2.c: New test.
next prev parent reply other threads:[~2023-07-10 14:15 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-15 15:59 [Bug target/110268] New: " clyon at gcc dot gnu.org 2023-06-15 16:01 ` [Bug target/110268] [14 Regression] " acoplan at gcc dot gnu.org 2023-06-15 16:40 ` clyon at gcc dot gnu.org 2023-06-16 6:20 ` rguenth at gcc dot gnu.org 2023-06-16 6:21 ` rguenth at gcc dot gnu.org 2023-06-19 12:38 ` clyon at gcc dot gnu.org 2023-07-10 14:15 ` cvs-commit at gcc dot gnu.org [this message] 2023-07-10 14:16 ` clyon at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110268-4-tGbemqnAVk@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).