public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/110276] [13/14 Regression] ICE building efibootguard on x86_64-linux-gnu
Date: Tue, 27 Jun 2023 16:02:27 +0000	[thread overview]
Message-ID: <bug-110276-4-CX4Ouh70rD@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110276-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110276

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Martin Jambor
<jamborm@gcc.gnu.org>:

https://gcc.gnu.org/g:7085905d7842e71af7a59c7d20d050716dd22e9b

commit r13-7483-g7085905d7842e71af7a59c7d20d050716dd22e9b
Author: Martin Jambor <mjambor@suse.cz>
Date:   Tue Jun 27 18:01:13 2023 +0200

    ipa-sra: Disable candidates with no known callers (PR 110276)

    In IPA-SRA we use can_be_local_p () predicate rather than just plain
    local call graph flag in order to figure out whether the node is a
    part of an external API that we cannot change.  Although there are
    cases where this can allow more transformations, it also means we can
    analyze functions which have no callers at all, which is pointless.

    Moreover, it makes an assert of hint propagation trigger, which checks
    that we have looked at callers before processing hints that come from
    them.  This has been reported as PR 110276.

    This patch simply adds a check that a node has at least one caller
    into the early checks and makes the node a non-candidate for any
    transformation if it does not.

    gcc/ChangeLog:

    2023-06-16  Martin Jambor  <mjambor@suse.cz>

            PR ipa/110276
            * ipa-sra.cc (struct caller_issues): New field there_is_one.
            (check_for_caller_issues): Set it.
            (check_all_callers_for_issues): Check it.

    gcc/testsuite/ChangeLog:

    2023-06-16  Martin Jambor  <mjambor@suse.cz>

            PR ipa/110276
            * gcc.dg/ipa/pr110276.c: New test.

    (cherry picked from commit 8a665a8d3b45c947d5793e2c9c3df8a1c0302f03)

  parent reply	other threads:[~2023-06-27 16:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16  5:13 [Bug ipa/110276] New: [13 " doko at gcc dot gnu.org
2023-06-16  8:36 ` [Bug ipa/110276] [13/14 " rguenth at gcc dot gnu.org
2023-06-16 13:48 ` jamborm at gcc dot gnu.org
2023-06-16 16:18 ` jamborm at gcc dot gnu.org
2023-06-20 16:17 ` cvs-commit at gcc dot gnu.org
2023-06-27 16:02 ` cvs-commit at gcc dot gnu.org [this message]
2023-06-27 16:05 ` jamborm at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110276-4-CX4Ouh70rD@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).