[Bug c++/110295] [10/11/12/13/14 Regression] ICE in dwarf2out_finish with local class with inherited operator delete in a templated function and -g

["rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110295

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
           Keywords|needs-bisection             |

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
(gdb) p debug_dwarf_die (deferred_asm_name->die)
DIE    0: DW_TAG_subprogram (0x7ffff6e4aaa0)
  abbrev id: 0 offset: 0 mark: 0
  DW_AT_external: 1
  DW_AT_name: "thing_t"
  DW_AT_artificial: 1
  DW_AT_declaration: 1
  DW_AT_object_pointer: die -> 0 (0x7ffff6e4aaf0)
    DIE    0: DW_TAG_formal_parameter (0x7ffff6e4aaf0)
      abbrev id: 0 offset: 0 mark: 0
      DW_AT_type: die -> 0 (0x7ffff6e4a1e0)
      DW_AT_artificial: 1
(gdb) p deferred_asm_name->created_for 
$4 = <function_decl 0x7ffff6feaa00 __ct >

created via

(gdb) bt
#0  add_linkage_name_raw (
    die=<dw_die_ref 0x7ffff6e4aaa0 DW_TAG_subprogram <parent=0x7ffff6e4a230
DW_TAG_structure_type>>, decl=<function_decl 0x7ffff6feaa00 __ct >)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:22023
#1  0x00000000013ef18a in add_linkage_name (
    die=<dw_die_ref 0x7ffff6e4aaa0 DW_TAG_subprogram <parent=0x7ffff6e4a230
DW_TAG_structure_type>>, decl=<function_decl 0x7ffff6feaa00 __ct >)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:22047
#2  0x00000000013ef2b8 in add_name_and_src_coords_attributes (
    die=<dw_die_ref 0x7ffff6e4aaa0 DW_TAG_subprogram <parent=0x7ffff6e4a230
DW_TAG_structure_type>>, decl=<function_decl 0x7ffff6feaa00 __ct >, 
    no_linkage_name=false)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:22072
#3  0x00000000013f363d in gen_subprogram_die (
    decl=<function_decl 0x7ffff6feaa00 __ct >, 
    context_die=<dw_die_ref 0x7ffff6e4a230 DW_TAG_structure_type
<parent=0x7ffff6e4a410 DW_TAG_subprogram>>)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:23701
#4  0x00000000013fda8f in gen_decl_die (
    decl=<function_decl 0x7ffff6feaa00 __ct >, origin=<tree 0x0>, 
    ctx=0x7fffffffd1b0, 
    context_die=<dw_die_ref 0x7ffff6e4a230 DW_TAG_structure_type
<parent=0x7ffff6e4a410 DW_TAG_subprogram>>)
#5  0x00000000013f9dc5 in gen_member_die (
    type=<record_type 0x7ffff6fdeb28 thing_t>, 
    context_die=<dw_die_ref 0x7ffff6e4a230 DW_TAG_structure_type
<parent=0x7ffff6e4a410 DW_TAG_subprogram>>)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:25858
#6  0x00000000013fa517 in gen_struct_or_union_type_die (
    type=<record_type 0x7ffff6fdeb28 thing_t>, 
    context_die=<dw_die_ref 0x7ffff6e4a410 DW_TAG_subprogram
<parent=0x7ffff6e4a000 DW_TAG_compile_unit>>, usage=DINFO_USAGE_DIR_USE)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:25954
#7  0x00000000013faff8 in gen_tagged_type_die (
    type=<record_type 0x7ffff6fdeb28 thing_t>, 
    context_die=<dw_die_ref 0x7ffff6e4a410 DW_TAG_subprogram
<parent=0x7ffff6e4a000 DW_TAG_compile_unit>>, usage=DINFO_USAGE_DIR_USE)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:26155
#8  0x00000000013fb94f in gen_type_die_with_usage (
    type=<record_type 0x7ffff6fdeb28 thing_t>, 
    context_die=<dw_die_ref 0x7ffff6e4a410 DW_TAG_subprogram
<parent=0x7ffff6e4a000 DW_TAG_compile_unit>>, usage=DINFO_USAGE_DIR_USE)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:26349
#9  0x00000000013fbcec in gen_type_die (
    type=<record_type 0x7ffff6fdeb28 thing_t>, 
    context_die=<dw_die_ref 0x7ffff6e4a410 DW_TAG_subprogram
<parent=0x7ffff6e4a000 DW_TAG_compile_unit>>)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:26404
#10 0x00000000013fdc7f in gen_decl_die (
    decl=<type_decl 0x7ffff6fe51c8 thing_t>, origin=<tree 0x0>, ctx=0x0, 
    context_die=<dw_die_ref 0x7ffff6e4a410 DW_TAG_subprogram
<parent=0x7ffff6e4a000 DW_TAG_compile_unit>>)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:27043
#11 0x00000000013fc3e4 in process_scope_var (stmt=<block 0x7ffff6fd06c0>, 
    decl=<type_decl 0x7ffff6fe51c8 thing_t>, origin=<tree 0x0>, 
    context_die=<dw_die_ref 0x7ffff6e4a410 DW_TAG_subprogram
<parent=0x7ffff6e4a000 DW_TAG_compile_unit>>)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:26557
#12 0x00000000013fc46d in decls_for_scope (stmt=<block 0x7ffff6fd06c0>, 
    context_die=<dw_die_ref 0x7ffff6e4a410 DW_TAG_subprogram
<parent=0x7ffff6e4a000 DW_TAG_compile_unit>>, recurse=true)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:26583
#13 0x00000000013f4757 in gen_subprogram_die (
    decl=<function_decl 0x7ffff6fcb900 exercise>, 
    context_die=<dw_die_ref 0x7ffff6e4a000 DW_TAG_compile_unit>)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:24087
#14 0x00000000013fda8f in gen_decl_die (
    decl=<function_decl 0x7ffff6fcb900 exercise>, origin=<tree 0x0>, ctx=0x0, 
    context_die=<dw_die_ref 0x7ffff6e4a000 DW_TAG_compile_unit>)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:27020
#15 0x00000000013ff1da in dwarf2out_decl (
    decl=<function_decl 0x7ffff6fcb900 exercise>)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:27601
#16 0x00000000013ff239 in dwarf2out_function_decl (
    decl=<function_decl 0x7ffff6fcb900 exercise>)
    at /space/rguenther/src/gcc11queue/gcc/dwarf2out.cc:27616
#17 0x00000000014bfa35 in rest_of_handle_final ()
    at /space/rguenther/src/gcc11queue/gcc/final.cc:4274

interestingly we do not arrive at the member DIE creation of the typedef
from the outermost frames.  In fact we create the type DIE for
thing_t before processing the local typedef decl but there it's not
final it seems but simply

 <record_type 0x7ffff6fdeb28 thing_t cxx-odr-p type_5 type_6 VOID
    align:8 warn_if_not_align:0 symtab:0 alias-set -1 canonical-type
0x7ffff6fdeb28 context <function_decl 0x7ffff6fcb900 exercise>
    full-name "struct exercise<1>()::thing_t"
    no-binfo use_template=1 interface-unknown
    pointer_to_this <pointer_type 0x7ffff6fded20> chain <type_decl
0x7ffff6fe51c8 thing_t>>

and we then run into

/* Process variable DECL (or variable with origin ORIGIN) within
   block STMT and add it to CONTEXT_DIE.  */
static void
process_scope_var (tree stmt, tree decl, tree origin, dw_die_ref context_die)
{
...
  if (die != NULL && die->die_parent == NULL)
    add_child_die (context_die, die);

because appearantly we have created the DIE in limbo.  Of course when
running into this code late we now have a parent and end up creating
the decl DIE.

I think we want to continue creating the DIE for the decl here.  The following
fixes this issue.

diff --git a/gcc/dwarf2out.cc b/gcc/dwarf2out.cc
index d89ffa66847..e70c47cec8d 100644
--- a/gcc/dwarf2out.cc
+++ b/gcc/dwarf2out.cc
@@ -26533,7 +26533,8 @@ process_scope_var (tree stmt, tree decl, tree origin,
dw_die_ref context_die)

   if (die != NULL && die->die_parent == NULL)
     add_child_die (context_die, die);
-  else if (TREE_CODE (decl_or_origin) == IMPORTED_DECL)
+
+  if (TREE_CODE (decl_or_origin) == IMPORTED_DECL)
     {
       if (early_dwarf)
        dwarf2out_imported_module_or_decl_1 (decl_or_origin, DECL_NAME
(decl_or_origin),