From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id D47153858D1E; Tue, 20 Jun 2023 06:58:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D47153858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1687244312; bh=co0q4VIF0rIOZu5c0Yqtq5gKgs3VukWl5VJi3dF26Xw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=A5DCgSkkCaLKilb4017zzONpXCKfH2FqJMBgw8vU8rQrcoT/OFf6tJFtdeLwZZep+ R4rduf6B+aLnE3bPY96ptCEoqjErwCbbXHDgR9Rb16n6dTZf1xACjRiR6q7CN0bWNa W5S8PRybiG2v6R6wK+wLBZZzgHNkbcfFIJ7eFz9k= From: "pinskia at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/110316] [10/11/12/13/14 Regression] g++.dg/ext/timevar1.C and timevar2.C fail erratically Date: Tue, 20 Jun 2023 06:58:32 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: middle-end X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: ice-on-valid-code X-Bugzilla-Severity: normal X-Bugzilla-Who: pinskia at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 10.5 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: everconfirmed target_milestone cf_known_to_fail cf_reconfirmed_on component short_desc keywords bug_status cf_known_to_work Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110316 Andrew Pinski changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Target Milestone|--- |10.5 Known to fail| |4.8.0 Last reconfirmed| |2023-06-20 Component|testsuite |middle-end Summary|[14 regression] |[10/11/12/13/14 Regression] |g++.dg/ext/timevar1.C and |g++.dg/ext/timevar1.C and |timevar2.C fail erratically |timevar2.C fail erratically Keywords| |ice-on-valid-code Status|UNCONFIRMED |NEW Known to work| |4.7.0 --- Comment #1 from Andrew Pinski --- I would not call this a regression from GCC 13 but from much earlier, r0-117422-ga910399dfd44. The check is definitely wrong since wall difference is less than ticks_to_m= sec here. Most likely the check should be rather: if (phase_user > total->user + toleranceu || phase_sys > total->sys + tolerances || phase_wall > total->wall + tolerancew || phase_ggc_mem > total->ggc_mem * tolerance) Where toleranceu, etc. should be defined as: tolerancew =3D total->user * (tolerance - 1); toleranceu =3D total->user * (tolerance - 1); tolerances =3D total->sys * (tolerance - 1); #ifdef USE_TIMES if (tolerancew < ticks_to_msec) tolerancew =3D ticks_to_msec; if (toleranceu < ticks_to_msec) toleranceu =3D ticks_to_msec; if (tolerances < ticks_to_msec) tolerances =3D ticks_to_msec; #endif #ifdef USE_GETRUSAGE toleranceu =3D total->user * (tolerance - 1); tolerances =3D total->sys * (tolerance - 1); #endif #ifdef USE_CLOCK if (toleranceu < clocks_to_msec) toleranceu =3D clocks_to_msec; #endif The reasoning is the tolerance should be at min a tick.=