From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id B7D693858401; Wed, 28 Jun 2023 21:06:26 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7D693858401
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1687986386;
	bh=6c5H9zPlcA5d6RWSCcfnSv7awnYTmpb8ZMTsETQI1mM=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=MwK8S7L+dyXySVb7YVBcIYh8CUwHvafrrFEpkeOy7R5LolXKwazbn+ciWllHhBN37
	 Il32/FjV8BkKID317HllGTC3vRyOUpvymVTyX9L8JNUuSpZhvXB66Tx83OFYcXhU8Y
	 3qJ5aFgMVxVYZS9lgWR+IFvaJIpADVTu2k0TitT8=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/110334] [13/14 Regresssion] unused functions not eliminated
 before LTO streaming
Date: Wed, 28 Jun 2023 21:06:25 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 13.1.1
X-Bugzilla-Keywords: lto, missed-optimization
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.2
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-110334-4-gxNwQAnqRY@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-110334-4@http.gcc.gnu.org/bugzilla/>
References: <bug-110334-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110334

--- Comment #17 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jan Hubicka <hubicka@gcc.gnu.org>:

https://gcc.gnu.org/g:d88fd2e1d0720e6f892da9ff48e9a301a7ad0ad4

commit r14-2172-gd88fd2e1d0720e6f892da9ff48e9a301a7ad0ad4
Author: Jan Hubicka <jh@suse.cz>
Date:   Wed Jun 28 23:05:28 2023 +0200

    Enable early inlining into always_inline functions

    Early inliner currently skips always_inline functions and moreover we
ignore
    calls from always_inline in ipa_reverse_postorder.  This leads to disab=
ling
    most of propagation done using early optimization that is quite bad when
    early inline functions are not leaf functions, which is now quite common
    in libstdc++.

    This patch instead of fully disabling the inline checks calls in callee.
    I am quite conservative about what can be inlined as this patch is bit
    touchy anyway.  To avoid problems with always_inline being optimized
    after early inline I extended inline_always_inline_functions to lazilly
    compute fnsummary when needed.

    gcc/ChangeLog:

            PR middle-end/110334
            * ipa-fnsummary.h (ipa_fn_summary): Add
            safe_to_inline_to_always_inline.
            * ipa-inline.cc (can_early_inline_edge_p): ICE
            if SSA is not built; do cycle checking for
            always_inline functions.
            (inline_always_inline_functions): Be recrusive;
            watch for cycles; do not updat overall summary.
            (early_inliner): Do not give up on always_inlines.
            * ipa-utils.cc (ipa_reverse_postorder): Do not skip
            always inlines.

    gcc/testsuite/ChangeLog:

            PR middle-end/110334
            * g++.dg/opt/pr66119.C: Disable early inlining.
            * gcc.c-torture/compile/pr110334.c: New test.
            * gcc.dg/tree-ssa/pr110334.c: New test.=