public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/110386] [11/12 Regression] ICE with ABSU in backprop Date: Thu, 09 May 2024 07:27:47 +0000 [thread overview] Message-ID: <bug-110386-4-ke8CalUEUp@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-110386-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110386 --- Comment #12 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-11 branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>: https://gcc.gnu.org/g:dbfc2d075f10149bd94e16c1210ffe4bac7e60c3 commit r11-11422-gdbfc2d075f10149bd94e16c1210ffe4bac7e60c3 Author: Andrew Pinski <apinski@marvell.com> Date: Sat Sep 23 21:53:09 2023 -0700 Fix PR 110386: backprop vs ABSU_EXPR The issue here is that when backprop tries to go and strip sign ops, it skips over ABSU_EXPR but ABSU_EXPR not only does an ABS, it also changes the type to unsigned. Since strip_sign_op_1 is only supposed to strip off sign changing operands and not ones that change types, removing ABSU_EXPR here is correct. We don't handle nop conversions so this does cause any missed optimizations either. OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. PR tree-optimization/110386 gcc/ChangeLog: * gimple-ssa-backprop.c (strip_sign_op_1): Remove ABSU_EXPR. gcc/testsuite/ChangeLog: * gcc.c-torture/compile/pr110386-1.c: New test. * gcc.c-torture/compile/pr110386-2.c: New test. (cherry picked from commit 2bbac12ea7bd8a3eef5382e1b13f6019df4ec03f)
next prev parent reply other threads:[~2024-05-09 7:27 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-24 0:55 [Bug target/110386] New: [14 Regression] ICE when optimizing VPABSD/VPMULLD since 07b86ab138bf8be8cb331015cd2b9775c6856ac6 benjsith at gmail dot com 2023-06-24 0:58 ` [Bug target/110386] [14 Regression] ICE when optimizing VPABSD/VPMULLD since g:07b86ab138bf8be8cb331015cd2b9775c6856ac6 pinskia at gcc dot gnu.org 2023-06-24 1:01 ` [Bug tree-optimization/110386] " pinskia at gcc dot gnu.org 2023-06-24 2:06 ` [Bug tree-optimization/110386] [12/13/14 Regression] ICE with ABSU in backprop pinskia at gcc dot gnu.org 2023-06-24 2:09 ` [Bug tree-optimization/110386] [10/11/12/13/14 " pinskia at gcc dot gnu.org 2023-06-26 9:00 ` rguenth at gcc dot gnu.org 2023-07-07 10:45 ` [Bug tree-optimization/110386] [11/12/13/14 " rguenth at gcc dot gnu.org 2023-09-18 0:26 ` pinskia at gcc dot gnu.org 2023-09-24 23:46 ` pinskia at gcc dot gnu.org 2023-09-25 7:08 ` cvs-commit at gcc dot gnu.org 2023-09-25 7:09 ` [Bug tree-optimization/110386] [11/12/13 " pinskia at gcc dot gnu.org 2023-10-01 19:28 ` cvs-commit at gcc dot gnu.org 2024-05-09 7:25 ` [Bug tree-optimization/110386] [11/12 " cvs-commit at gcc dot gnu.org 2024-05-09 7:27 ` cvs-commit at gcc dot gnu.org [this message] 2024-05-09 7:28 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110386-4-ke8CalUEUp@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).