public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "hliu at amperecomputing dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/110449] Vect: use a small step to calculate the loop induction if the loop is unrolled during loop vectorization Date: Thu, 29 Jun 2023 03:15:03 +0000 [thread overview] Message-ID: <bug-110449-4-23dUeyIQuk@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-110449-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110449 --- Comment #2 from Hao Liu <hliu at amperecomputing dot com> --- That looks better than the currently generated code (it saves one "MOV" instruction). Yes, it has the loop-carried dependency advantage. But it still uses one more register for "8*step" (There may be a register pressure problem for complicated code, not for this simple case). This is still a floating point precision problem. There is a PR84201 discussed about the same problem for X86: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84201. The larger step makes the floating point calculation result has larger gap compared to the original scalar calculation result. E.g. The SPEC2017 fp benchmark 549.fotonik may result in VE (Validation Error) after unrolling a loop of double: 319 do ifreq = 1, tmppower%nofreq <------ HERE 320 frequency(ifreq,ipower) = freq 321 freq = freq + freqstep 322 end do it uses 4*step for unrolled vectorization version other than the 2*step for non-unrolled vectorization version. The SPEC fp result checks the "relative tolerance" of the fp results and it is higher than the current standard (i.e. the compare command line option of "--reltol 1e-10").
next prev parent reply other threads:[~2023-06-29 3:15 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-28 9:22 [Bug tree-optimization/110449] New: " hliu at amperecomputing dot com 2023-06-28 20:11 ` [Bug tree-optimization/110449] " rsandifo at gcc dot gnu.org 2023-06-29 3:15 ` hliu at amperecomputing dot com [this message] 2023-07-06 16:05 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110449-4-23dUeyIQuk@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).