public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/110554] veclowering introduces invalid wide Boolean values
Date: Wed, 05 Jul 2023 07:13:31 +0000	[thread overview]
Message-ID: <bug-110554-4-RNHcdDbzYM@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110554-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110554

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #6)
> Created attachment 55472 [details]
> Fix veclowering types
> 
> So the problem is veclowering should have just use boolean_type_node here
> for the comparison.
> 
> There is another type issue when dealing with not a comparison and not 
> scalar bitmask which fix is included here.
> 
> Still need to test it.

I think this gets the case wrong where lowering splits a wide vector into
smaller vectors.  I think 'cond_type' is wrong in this case already,
but unconditionally using boolean_type_node looks wrong as well.
In the small vector case the code also uses COND_EXPR instead of
VEC_COND_EXPR.  Hmm, maybe we don't support big to small vector split
here at all ... in that case the patch looks good to me.

  parent reply	other threads:[~2023-07-05  7:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04 23:00 [Bug tree-optimization/110554] New: more " kristerw at gcc dot gnu.org
2023-07-05  0:02 ` [Bug tree-optimization/110554] " pinskia at gcc dot gnu.org
2023-07-05  0:29 ` [Bug tree-optimization/110554] veclowering introduces " pinskia at gcc dot gnu.org
2023-07-05  2:10 ` pinskia at gcc dot gnu.org
2023-07-05  2:53 ` pinskia at gcc dot gnu.org
2023-07-05  3:05 ` pinskia at gcc dot gnu.org
2023-07-05  3:37 ` pinskia at gcc dot gnu.org
2023-07-05  7:13 ` rguenth at gcc dot gnu.org [this message]
2023-07-06  6:20 ` cvs-commit at gcc dot gnu.org
2023-07-06  6:20 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110554-4-RNHcdDbzYM@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).