public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/110556] [12/13/14 Regression] division of INT_MIN and -1 happening incorrectly with -fno-delete-dead-exceptions -fnon-call-exceptions
Date: Thu, 06 Jul 2023 11:45:21 +0000	[thread overview]
Message-ID: <bug-110556-4-CFDdmQf9s1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110556-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110556

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
The issue is tail merging and I think we have a duplicate bug for this.

find_duplicates: <bb 5> duplicate of <bb 7>
Removing basic block 7
;; basic block 7, loop depth 0
;;  pred:
_27 = -9223372036854775808 / si2_15(D);
goto <bb 10>; [100.00%]

and we have

  <bb 4> [local count: 268435457]:
  _5 = si2_15(D) > 0;
  _6 = _1 | _5;
  if (_6 != 0)
    goto <bb 6>; [20.00%]
  else
    goto <bb 5>; [80.00%]

  <bb 5> [local count: 214748365]:
  _13 = -9223372036854775808 / si1_14(D);
  goto <bb 10>; [100.00%]

  <bb 6> [local count: 301989889]:
  _7 = si1_14(D) > 0;
  _9 = _2 | _7;
  if (_9 != 0)
    goto <bb 8>; [0.00%]
  else
    goto <bb 7>; [100.00%]

  <bb 7> [local count: 301989888]:
  _27 = -9223372036854775808 / si2_15(D);
  goto <bb 10>; [100.00%]

oddly enough gimple_equal_p looks strange:

    case GIMPLE_ASSIGN:
      lhs1 = gimple_get_lhs (s1);
      lhs2 = gimple_get_lhs (s2);
      if (TREE_CODE (lhs1) != SSA_NAME
          && TREE_CODE (lhs2) != SSA_NAME)
        return (operand_equal_p (lhs1, lhs2, 0)
                && gimple_operand_equal_value_p (gimple_assign_rhs1 (s1),
                                                 gimple_assign_rhs1 (s2)));
      else if (TREE_CODE (lhs1) == SSA_NAME
               && TREE_CODE (lhs2) == SSA_NAME)
        return operand_equal_p (gimple_assign_rhs1 (s1),
                                gimple_assign_rhs1 (s2), 0);

that looks pre-tuplish to me.

  parent reply	other threads:[~2023-07-06 11:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-05  9:19 [Bug c/110556] New: Floating point exception with specific optimizations 19373742 at buaa dot edu.cn
2023-07-05  9:20 ` [Bug c/110556] " 19373742 at buaa dot edu.cn
2023-07-05 10:30 ` 19373742 at buaa dot edu.cn
2023-07-05 17:54 ` pinskia at gcc dot gnu.org
2023-07-05 21:28 ` [Bug middle-end/110556] " pinskia at gcc dot gnu.org
2023-07-05 22:32 ` pinskia at gcc dot gnu.org
2023-07-06  1:36 ` 19373742 at buaa dot edu.cn
2023-07-06  1:38 ` pinskia at gcc dot gnu.org
2023-07-06  5:30 ` pinskia at gcc dot gnu.org
2023-07-06  5:42 ` [Bug middle-end/110556] [12/13/14 Regression] " pinskia at gcc dot gnu.org
2023-07-06  8:15 ` [Bug tree-optimization/110556] [12/13/14 Regression] division of INT_MIN and -1 happening incorrectly with -fno-delete-dead-exceptions -fnon-call-exceptions rguenth at gcc dot gnu.org
2023-07-06 11:45 ` rguenth at gcc dot gnu.org [this message]
2023-07-06 13:24 ` cvs-commit at gcc dot gnu.org
2023-07-07 12:07 ` [Bug tree-optimization/110556] [12 " cvs-commit at gcc dot gnu.org
2023-11-27 11:35 ` cvs-commit at gcc dot gnu.org
2023-11-27 11:36 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110556-4-CFDdmQf9s1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).