From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 8699F3858280; Wed, 19 Jul 2023 22:43:06 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8699F3858280
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1689806586;
	bh=2RTEXNCvCifyp0Ans0mVU/6pm+ddAxKjzM5HKWE06nc=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=surdfbK+Xtmu2ioVa9QcXTg383qKe0AzDjv0RlBpoQb+6u155hstDZ/8DxItAMfmm
	 RPrMXnMzwJVwzruBESwDtFAOMmEpD2h+zWPl+vwFwBnbcrLTcNsvYEtKDR8eNXaXSe
	 d2Y25Pj5c7eLrr3QFd8j2R/jEupocSEdc0e73QNI=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/110593] The std::ratio meta arithmetic can accept
 non-std::ratio
Date: Wed, 19 Jul 2023 22:43:06 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: accepts-invalid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: redi at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-110593-4-CIjkHKMjel@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-110593-4@http.gcc.gnu.org/bugzilla/>
References: <bug-110593-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110593

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:2d614822e9ea2a3d8800045d66e3220743753d09

commit r14-2660-g2d614822e9ea2a3d8800045d66e3220743753d09
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Jul 19 18:18:46 2023 +0100

    libstdc++: Check for std::ratio in arithmetic and comparisons [PR110593]

    The standard says that it should be ill-formed to use std::ratio_equal
    etc. with types which are not specializations of std::ratio. This
    implements that requirement.

    We don't need to add assertions to every one of the class templates,
    because many of them are implemented in terms of other ones. For
    example, ratio_divide and ratio_subtract can rely on the assertions in
    ratio_multiply and ratio_add respectively.

    libstdc++-v3/ChangeLog:

            PR libstdc++/110593
            * include/bits/chrono.h (duration): Improve static assert
            messages.
            (__is_ratio): Move to ...
            * include/std/ratio (__is_ratio): ... here.
            (__is_ratio_v): New variable template and partial
            specialization.
            (__are_both_ratios): New function template.
            (__ratio_multiply, ratio_equal, ratio_less, __ratio_add):
            Add static assertion.
            * testsuite/20_util/ratio/requirements/type_constraints.cc:
            New test.
            * testsuite/20_util/duration/requirements/typedefs_neg1.cc:
            Adjust expected error.
            * testsuite/20_util/duration/requirements/typedefs_neg2.cc:
            Likewise.=