From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 82532385B81D; Wed, 26 Jul 2023 01:45:36 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 82532385B81D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1690335936;
	bh=pQMe9hpy2tP89qPsbb1lK0GWuCjMfr8aG90R/M4UG+Y=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=ef8+bXx174nS/rmSDcmL9owLMBwuI8u2x5qToE45JBjU7Iv81tbOqd1/TojlFo4oF
	 Pg1PX7fbZh1103HxlKx2pcw7Z5pd6mbYTdKg6dK9JMwfa3VHt8AI4cX6mHv6443+Li
	 KzynWiBda3JnojM0niEd1IoQP5ahzj78tvTRA0wg=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/110619] Dangling pointer returned from constexpr function
 converts in nullptr
Date: Wed, 26 Jul 2023 01:45:35 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 13.1.0
X-Bugzilla-Keywords: accepts-invalid, diagnostic, rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-110619-4-4a4nETuKy8@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-110619-4@http.gcc.gnu.org/bugzilla/>
References: <bug-110619-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110619

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:b8266af71c19a0bd7db4d08c8d2ee3c33214508c

commit r14-2772-gb8266af71c19a0bd7db4d08c8d2ee3c33214508c
Author: Nathaniel Shead <nathanieloshead@gmail.com>
Date:   Sun Jul 23 01:14:37 2023 +1000

    c++: Prevent dangling pointers from becoming nullptr in constexpr
[PR110619]

    Currently, when typeck discovers that a return statement will refer to a
    local variable it rewrites to return a null pointer. This causes the
    error messages for using the return value in a constant expression to be
    unhelpful, especially for reference return values, and is also a visible
    change to otherwise valid code (as in the linked PR).

    The transformation is nonetheless important, however, both as a safety
    guard against attackers being able to gain a handle to other data on the
    stack, and to prevent duplicate warnings from later null-dereference
    warning passes.

    As such, this patch just delays the transformation until cp_genericize,
    after constexpr function definitions have been generated.

            PR c++/110619

    gcc/cp/ChangeLog:

            * cp-gimplify.cc (cp_genericize_r): Transform RETURN_EXPRs to
            not return dangling pointers.
            * cp-tree.h (RETURN_EXPR_LOCAL_ADDR_P): New flag.
            (check_return_expr): Add a new parameter.
            * semantics.cc (finish_return_stmt): Set flag on RETURN_EXPR
            when referring to dangling pointer.
            * typeck.cc (check_return_expr): Disable transformation of
            dangling pointers, instead pass this information to caller.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp1y/constexpr-110619.C: New test.

    Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>=