public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/110625] [14 Regression][AArch64] Vect: SLP fails to vectorize a loop as the reduction_latency calculated by new costs is too large Date: Fri, 29 Dec 2023 15:59:38 +0000 [thread overview] Message-ID: <bug-110625-4-tMRZXvDsNi@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-110625-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110625 --- Comment #24 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>: https://gcc.gnu.org/g:984bdeaa39b6417b11736b2c167ef82119e272dc commit r14-6865-g984bdeaa39b6417b11736b2c167ef82119e272dc Author: Tamar Christina <tamar.christina@arm.com> Date: Fri Dec 29 15:58:29 2023 +0000 AArch64: Update costing for vector conversions [PR110625] In gimple the operation short _8; double _9; _9 = (double) _8; denotes two operations on AArch64. First we have to widen from short to long and then convert this integer to a double. Currently however we only count the widen/truncate operations: (double) _5 6 times vec_promote_demote costs 12 in body (double) _5 12 times vec_promote_demote costs 24 in body but not the actual conversion operation, which needs an additional 12 instructions in the attached testcase. Without this the attached testcase ends up incorrectly thinking that it's beneficial to vectorize the loop at a very high VF = 8 (4x unrolled). Because we can't change the mid-end to account for this the costing code in the backend now keeps track of whether the previous operation was a promotion/demotion and ajdusts the expected number of instructions to: 1. If it's the first FLOAT_EXPR and the precision of the lhs and rhs are different, double it, since we need to convert and promote. 2. If it's the previous operation was a demonition/promotion then reduce the cost of the current operation by the amount we added extra in the last. with the patch we get: (double) _5 6 times vec_promote_demote costs 24 in body (double) _5 12 times vec_promote_demote costs 36 in body which correctly accounts for 30 operations. This fixes the 16% regression in imagick in SPECCPU 2017 reported on Neoverse N2 and using the new generic Armv9-a cost model. gcc/ChangeLog: PR target/110625 * config/aarch64/aarch64.cc (aarch64_vector_costs::add_stmt_cost): Adjust throughput and latency calculations for vector conversions. (class aarch64_vector_costs): Add m_num_last_promote_demote. gcc/testsuite/ChangeLog: PR target/110625 * gcc.target/aarch64/pr110625_4.c: New test. * gcc.target/aarch64/sve/unpack_fcvt_signed_1.c: Add --param aarch64-sve-compare-costs=0. * gcc.target/aarch64/sve/unpack_fcvt_unsigned_1.c: Likewise
next prev parent reply other threads:[~2023-12-29 15:59 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-11 9:15 [Bug target/110625] New: [AArch64] " hliu at amperecomputing dot com 2023-07-11 10:41 ` [Bug target/110625] " rguenth at gcc dot gnu.org 2023-07-12 0:58 ` hliu at amperecomputing dot com 2023-07-14 8:58 ` hliu at amperecomputing dot com 2023-07-18 10:41 ` rsandifo at gcc dot gnu.org 2023-07-18 12:03 ` rsandifo at gcc dot gnu.org 2023-07-19 2:57 ` hliu at amperecomputing dot com 2023-07-19 8:55 ` rsandifo at gcc dot gnu.org 2023-07-19 9:36 ` hliu at amperecomputing dot com 2023-07-28 16:50 ` rsandifo at gcc dot gnu.org 2023-07-28 16:53 ` rsandifo at gcc dot gnu.org 2023-07-31 2:45 ` hliu at amperecomputing dot com 2023-07-31 12:56 ` cvs-commit at gcc dot gnu.org 2023-08-01 9:09 ` tnfchris at gcc dot gnu.org 2023-08-01 9:19 ` tnfchris at gcc dot gnu.org 2023-08-01 9:45 ` hliu at amperecomputing dot com 2023-08-01 9:49 ` tnfchris at gcc dot gnu.org 2023-08-01 9:50 ` hliu at amperecomputing dot com 2023-08-01 13:49 ` tnfchris at gcc dot gnu.org 2023-08-02 3:49 ` hliu at amperecomputing dot com 2023-08-04 2:34 ` cvs-commit at gcc dot gnu.org 2023-12-08 10:20 ` [Bug target/110625] [14 Regression][AArch64] " tnfchris at gcc dot gnu.org 2023-12-12 16:26 ` tnfchris at gcc dot gnu.org 2023-12-26 14:55 ` tnfchris at gcc dot gnu.org 2023-12-29 15:59 ` cvs-commit at gcc dot gnu.org [this message] 2023-12-29 16:16 ` tnfchris at gcc dot gnu.org 2023-12-30 8:34 ` hliu at amperecomputing dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110625-4-tMRZXvDsNi@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).