public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/110653] Support std::stoi etc. without C99 APIs
Date: Thu, 13 Jul 2023 17:09:52 +0000	[thread overview]
Message-ID: <bug-110653-4-mjvlq6Tvqt@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110653-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110653

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to dave.anglin from comment #3)
> On 2023-07-13 9:46 a.m., redi at gcc dot gnu.org wrote:
> > Dave, does this patch work for hppa64-hp-hpux11.11 ?
> Yes.

Great - pushed to trunk.

> On hpux, double and long double have different representations (they are
> same on linux).  hpux11.11 has both
> strtod and strtold.  strtold is checked for:
> 
> /* Define to 1 if you have the `strtof' function. */
> /* #undef HAVE_STRTOF */
> 
> /* Define to 1 if you have the `strtold' function. */
> #define HAVE_STRTOLD 1

Ah yes. That comes from libstdc++-v3/linkage.m4 which I think I've never even
looked at before!

> There doesn't seem to be a configure check for strtod.

That's from C89 and we already assume that's available unconditionally e.g. for
this code in <cstdlib>:

  using ::strtod;
  using ::strtol;
  using ::strtoul;


I'm testing this, which should define std::stof and std::stold for hpux11.11:

--- a/libstdc++-v3/include/bits/basic_string.h
+++ b/libstdc++-v3/include/bits/basic_string.h
@@ -4148,12 +4148,14 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
   stod(const string& __str, size_t* __idx = 0)
   { return __gnu_cxx::__stoa(&std::strtod, "stod", __str.c_str(), __idx); }

-#if _GLIBCXX_USE_C99_STDLIB
+#if _GLIBCXX_USE_C99_STDLIB || _GLIBCXX_HAVE_STRTOF
   // NB: strtof vs strtod.
   inline float
   stof(const string& __str, size_t* __idx = 0)
   { return __gnu_cxx::__stoa(&std::strtof, "stof", __str.c_str(), __idx); }
+#endif

+#if _GLIBCXX_USE_C99_STDLIB || _GLIBCXX_HAVE_STRTOLD
   inline long double
   stold(const string& __str, size_t* __idx = 0)
   { return __gnu_cxx::__stoa(&std::strtold, "stold", __str.c_str(), __idx); }
@@ -4161,7 +4163,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
   inline long double
   stold(const string& __str, size_t* __idx = 0)
   { return std::stod(__str, __idx); }
-#endif // _GLIBCXX_USE_C99_STDLIB
+#endif

   // DR 1261. Insufficent overloads for to_string / to_wstring

  parent reply	other threads:[~2023-07-13 17:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13  9:40 [Bug libstdc++/110653] New: " redi at gcc dot gnu.org
2023-07-13  9:43 ` [Bug libstdc++/110653] " redi at gcc dot gnu.org
2023-07-13 13:46 ` redi at gcc dot gnu.org
2023-07-13 15:14 ` dave.anglin at bell dot net
2023-07-13 16:59 ` cvs-commit at gcc dot gnu.org
2023-07-13 17:09 ` redi at gcc dot gnu.org [this message]
2023-07-13 17:57 ` dave.anglin at bell dot net
2023-07-13 18:16 ` dave.anglin at bell dot net
2023-07-14  1:20 ` dave.anglin at bell dot net
2023-07-14  7:39 ` redi at gcc dot gnu.org
2023-07-14  9:58 ` redi at gcc dot gnu.org
2023-07-15 14:52 ` dave.anglin at bell dot net
2023-07-15 19:39 ` redi at gcc dot gnu.org
2023-07-19 10:04 ` cvs-commit at gcc dot gnu.org
2023-07-19 10:04 ` cvs-commit at gcc dot gnu.org
2023-07-19 10:04 ` cvs-commit at gcc dot gnu.org
2023-07-19 10:10 ` redi at gcc dot gnu.org
2023-07-19 10:10 ` redi at gcc dot gnu.org
2023-07-19 13:48 ` dave.anglin at bell dot net
2023-07-19 13:51 ` redi at gcc dot gnu.org
2023-07-21 18:25 ` dave.anglin at bell dot net
2023-07-21 18:27 ` redi at gcc dot gnu.org
2023-07-24 20:04 ` cvs-commit at gcc dot gnu.org
2023-08-10 19:25 ` danglin at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110653-4-mjvlq6Tvqt@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).