public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/110676] [11/12/13/14 Regression] strlen of array[1] should not be optimized to 0 if using ASAN
Date: Tue, 06 Feb 2024 12:00:53 +0000	[thread overview]
Message-ID: <bug-110676-4-huSFwV4tFU@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110676-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110676

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:d3eac7d96de790df51859f63c13838f153b416de

commit r14-8825-gd3eac7d96de790df51859f63c13838f153b416de
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Feb 6 13:00:04 2024 +0100

    asan: Don't fold some strlens with -fsanitize=address [PR110676]

    The UB on the following testcase isn't diagnosed by -fsanitize=address,
    because we see that the array has a single element and optimize the
    strlen to 0.  I think it is fine to assume e.g. for range purposes the
    lower bound for the strlen as long as we don't try to optimize
    strlen (str)
    where we know that it returns [26, 42] to
    26 + strlen (str + 26), but for the upper bound we really want to punt
    on optimizing that for -fsanitize=address to read all the bytes of the
    string and diagnose if we run to object end etc.

    2024-02-06  Jakub Jelinek  <jakub@redhat.com>

            PR sanitizer/110676
            * gimple-fold.cc (gimple_fold_builtin_strlen): For
-fsanitize=address
            reset maxlen to sizetype maximum.

            * gcc.dg/asan/pr110676.c: New test.

  parent reply	other threads:[~2024-02-06 12:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-15 18:28 [Bug sanitizer/110676] New: builtin optimization prevents ASan from detecting OOB reads nrk at disroot dot org
2023-07-15 18:32 ` [Bug sanitizer/110676] strlen of array[1] should not be optimized to 1 if using ASAN pinskia at gcc dot gnu.org
2023-07-15 18:35 ` [Bug sanitizer/110676] [11/12/13/14 Regression] " pinskia at gcc dot gnu.org
2023-07-15 18:35 ` nrk at disroot dot org
2024-02-05 20:23 ` [Bug sanitizer/110676] [11/12/13/14 Regression] strlen of array[1] should not be optimized to 0 " jakub at gcc dot gnu.org
2024-02-05 20:47 ` jakub at gcc dot gnu.org
2024-02-06 12:00 ` cvs-commit at gcc dot gnu.org [this message]
2024-02-06 12:01 ` [Bug sanitizer/110676] [11/12/13 " jakub at gcc dot gnu.org
2024-05-13 11:33 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110676-4-huSFwV4tFU@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).