public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/110754] assume create spurious load for volatile variable
Date: Sat, 02 Mar 2024 00:38:48 +0000	[thread overview]
Message-ID: <bug-110754-4-XBwEgln1dg@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110754-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110754

--- Comment #10 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:e084a6406ea0587beda62684b9d4856292acacfa

commit r13-8389-ge084a6406ea0587beda62684b9d4856292acacfa
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Feb 10 11:28:00 2024 +0100

    gimple-low: Fix up handling of volatile automatic vars in assume attribute
[PR110754]

    As the following testcases show, the gimple-low outlining of assume
    magic functions handled volatile automatic vars (including
    parameters/results) like non-volatile ones except it copied volatile
    to the new PARM_DECL, which has the undesirable effect that a load
    from the volatile var is passed to IFN_ASSUME and so there is a
    side-effect there even when side-effects of the assume attribute
    shouldn't be evaluated.

    The following patch fixes that by passing address of the volatile
    variables/parameters/results instead and doing loads or stores from it
    or to it where it was originally accessed in the assume attribute
    expression.

    2024-02-10  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/110754
            * gimple-low.cc (assumption_copy_decl): For TREE_THIS_VOLATILE
            decls create PARM_DECL with pointer to original type, set
            TREE_READONLY and keep TREE_THIS_VOLATILE, TREE_ADDRESSABLE,
            DECL_NOT_GIMPLE_REG_P and DECL_BY_REFERENCE cleared.
            (adjust_assumption_stmt_op): For remapped TREE_THIS_VOLATILE decls
            wrap PARM_DECL into a simple TREE_THIS_NO_TRAP MEM_REF.
            (lower_assumption): For TREE_THIS_VOLATILE vars pass ADDR_EXPR
            of the var as argument.

            * gcc.dg/attr-assume-6.c: New test.
            * g++.dg/cpp23/attr-assume12.C: New test.

    (cherry picked from commit 39920447f876128ff7942a9cd931021800865894)

  parent reply	other threads:[~2024-03-02  0:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 19:16 [Bug c++/110754] New: " muecker at gwdg dot de
2023-07-20 22:34 ` [Bug c++/110754] " xry111 at gcc dot gnu.org
2023-07-20 22:42 ` [Bug middle-end/110754] " pinskia at gcc dot gnu.org
2023-07-20 22:44 ` pinskia at gcc dot gnu.org
2023-07-20 22:45 ` xry111 at gcc dot gnu.org
2023-07-21  6:44 ` rguenth at gcc dot gnu.org
2023-07-21  8:33 ` muecker at gwdg dot de
2024-02-09  9:15 ` jakub at gcc dot gnu.org
2024-02-09 15:00 ` jakub at gcc dot gnu.org
2024-02-10 10:28 ` cvs-commit at gcc dot gnu.org
2024-03-02  0:38 ` cvs-commit at gcc dot gnu.org [this message]
2024-03-04 12:09 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110754-4-XBwEgln1dg@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).