From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 1F85C3858C66; Wed, 26 Jul 2023 02:54:57 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F85C3858C66
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1690340097;
	bh=phk441zmKizyNBgYSc4mL1g4Ke/mrZRLP0O3d2jZ7AU=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=f10aos9nhq1OnhifbZ1W+zxS1obS7OAqUs2MiWW4+ZcZimGkgduDxqjpay5hh6dfQ
	 l0tRxqRSaj2rfrLMiXyYB+3CCroSfJJGaBxRGkeYNdYkiYUWGM/NKSlrzKaWgu+eja
	 PN9ccqbHjNDr/11Tmt7yJhldQAlQBh5baASto1I8=
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/110776] [14 Regression] powerpc-darwin bootstrap broken
 after r14-2490 with ICE rs6000.cc:5069 building libgfortran
Date: Wed, 26 Jul 2023 02:54:56 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: build, ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: linkw at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: linkw at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-110776-4-HJFaOb9CLa@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-110776-4@http.gcc.gnu.org/bugzilla/>
References: <bug-110776-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110776

--- Comment #9 from Kewen Lin <linkw at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #8)
> (In reply to rguenther@suse.de from comment #7)
> > On Tue, 25 Jul 2023, linkw at gcc dot gnu.org wrote:
> >=20
> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110776
> > >=20
> > > --- Comment #6 from Kewen Lin <linkw at gcc dot gnu.org> ---
> > > (In reply to rguenther@suse.de from comment #5)
> > > > On Tue, 25 Jul 2023, linkw at gcc dot gnu.org wrote:
> > > >=20
> > > > I think apart from the consideration what a single element vector
> > > > is compared to a scalar, a more to-the-point fix is
> > > >=20
> > > >   if (VECTOR_TYPE_P (ltype)
> > > >       && memory_access_type !=3D VMAT_ELEMENTWISE)
> > >=20
> > > Thanks for the suggestion! I thought checking lnel can also cover
> > > VMAT_STRIDED_SLP's special case having const_nunits 1, but it seems i=
mpossible
> > > to have?
> >=20
> > I think so, unless I'm convinced with a testcase ;)

I guess there is no such test case. ;)

>=20
> (sorry for being a bit slow - we had a power outage that wasted most of t=
he
> day)
>=20
> Richi's suggested patch fixes build of a cross-build for powerpc-darwin a=
nd
> the test results look OK too.  A non-expert look at the code suggests that
> VMAT_ELEMENTWISE is already accounted for on the write side, so that we
> should not see a call to the costing code for the equivalent write-side.

Thanks Iain, I also bootstrapped and regtested the suggested fix on x86 and
powerpc64{,le}, just posted it for review at
https://gcc.gnu.org/pipermail/gcc-patches/2023-July/625484.html.=