public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "acoplan at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/110791] New: [12/13/14 Regression] arm: Wrong code with -Os -march=armv8.1-m.main Date: Mon, 24 Jul 2023 10:51:12 +0000 [thread overview] Message-ID: <bug-110791-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110791 Bug ID: 110791 Summary: [12/13/14 Regression] arm: Wrong code with -Os -march=armv8.1-m.main Product: gcc Version: 13.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: rtl-optimization Assignee: unassigned at gcc dot gnu.org Reporter: acoplan at gcc dot gnu.org Target Milestone: --- The following testcase is miscompiled since at least GCC 12 with -Os -march=armv8.1-m.main: void __attribute__ ((noinline)) foo (char *path, int *result) { char *p = path; while (p >= path && *p != '/') p--; while (p > path && p[-1] == '/') p--; if (p < path) *result = 1; } int main(void) { char path[4] = "usr"; int x = 0; foo (path + 2, &x); if (!x) __builtin_abort (); } Below is the assembly we currently generate together with comments showing how this goes wrong at runtime: foo: mov r3, r0 @ r3 <- (p = path) ldrb r2, [r3], #-1 @ r2 <- *p; p--; cmp r2, #47 it eq moveq r3, r0 @ if (r2 == 47) p <- path subs r2, r3, r0 cmp r0, r3 add r2, r2, #1 bhi .L9 @ if (path > p) goto .L9 [taken] adds r0, r0, #1 bne .L6 .L9: movs r2, #1 .L6: subs r2, r2, #1 @ r2 <- 0 [fall through from above] bne .L3 @ [not taken, r2 was #1] bcc .L4 @ [not taken] bx lr @ [return without setting *result = 1] .L3: ldrb r0, [r3, #-1]! cmp r0, #47 beq .L6 bx lr .L4: movs r3, #1 str r3, [r1] bx lr At -O2 the code is both correct and much better quality: foo: ldrb r3, [r0] @ zero_extendqisi2 cmp r3, #47 itt ne movne r3, #1 strne r3, [r1] bx lr
next reply other threads:[~2023-07-24 10:51 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-24 10:51 acoplan at gcc dot gnu.org [this message] 2023-07-24 11:24 ` [Bug rtl-optimization/110791] " xry111 at gcc dot gnu.org 2023-07-24 11:27 ` acoplan at gcc dot gnu.org 2023-07-24 11:29 ` xry111 at gcc dot gnu.org 2023-07-24 13:09 ` wilco at gcc dot gnu.org 2023-07-24 13:23 ` rguenth at gcc dot gnu.org 2023-07-24 14:39 ` acoplan at gcc dot gnu.org 2023-07-24 15:14 ` [Bug middle-end/110791] " wilco at gcc dot gnu.org 2024-03-07 23:28 ` [Bug rtl-optimization/110791] [12/13/14 Regression] arm: Wrong code with -Os -march=armv8.1-m.main (maybe fmodulo-sched related) law at gcc dot gnu.org 2024-06-20 9:13 ` [Bug rtl-optimization/110791] [12/13/14/15 " rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110791-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).