public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/110830] -Wanalyzer-use-of-uninitialized-value false negative due to use-after-free::supercedes_p.
Date: Thu, 07 Sep 2023 21:02:11 +0000	[thread overview]
Message-ID: <bug-110830-4-bNEhKmXhDH@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110830-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110830

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Benjamin Priour <vultkayn@gcc.gnu.org>:

https://gcc.gnu.org/g:7d2274b9e346f44f8f6598b9dbb9fa95259274a2

commit r14-3794-g7d2274b9e346f44f8f6598b9dbb9fa95259274a2
Author: benjamin priour <vultkayn@gcc.gnu.org>
Date:   Fri Sep 1 20:21:41 2023 +0200

    analyzer: Call off a superseding when diagnostics are unrelated [PR110830]

    Before this patch, a saved_diagnostic would supersede another at
    the same statement if and only its vfunc supercedes_p returned true
    for the other diagnostic's kind.
    That both warning were unrelated - i.e. resolving one would not fix
    the other - was not considered in making the above choice.

    This patch makes it so that two saved_diagnostics taking a different
    outcome of at least one common conditional branching cannot supersede
    each other.

    Signed-off-by: Benjamin Priour <vultkayn@gcc.gnu.org>
    Co-authored-by: David Malcolm <dmalcolm@redhat.com>
    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

    gcc/analyzer/ChangeLog:

            PR analyzer/110830
            * diagnostic-manager.cc
            (compatible_epaths_p): New function.
            (saved_diagnostic::supercedes_p): Now calls the above
            to determine if the diagnostics do overlap and the superseding
            may proceed.

    gcc/testsuite/ChangeLog:

            PR analyzer/110830
            * c-c++-common/analyzer/pr110830.c: New test.

      parent reply	other threads:[~2023-09-07 21:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-27 12:41 [Bug analyzer/110830] New: " vultkayn at gcc dot gnu.org
2023-07-31 22:40 ` [Bug analyzer/110830] " dmalcolm at gcc dot gnu.org
2023-07-31 22:43 ` dmalcolm at gcc dot gnu.org
2023-09-07 21:02 ` cvs-commit at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110830-4-bNEhKmXhDH@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).