public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/110843] [14 Regression] ICE in convert_insn, at config/i386/i386-features.cc:1438 since r14-2405-g4814b63c3c2326
Date: Mon, 31 Jul 2023 07:09:43 +0000	[thread overview]
Message-ID: <bug-110843-4-OqxCVF88KD@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110843-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110843

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Roger Sayle <sayle@gcc.gnu.org>:

https://gcc.gnu.org/g:129feec0ba4f8ce74edf1fdf7da37b54968d3d37

commit r14-2874-g129feec0ba4f8ce74edf1fdf7da37b54968d3d37
Author: Roger Sayle <roger@nextmovesoftware.com>
Date:   Mon Jul 31 08:08:11 2023 +0100

    [Committed] PR target/110843: Check TARGET_AVX512VL for V2DI rotates in
STV.

    This patch resolves PR target/110843, an ICE caused by my enhancement to
    support AVX512 DImode and SImode rotates in the scalar-to-vector (STV)
pass.
    Although the vprotate instructions are available on all TARGET_AVX512F
    microarchitectures, the V2DI and V4SI variants are only available on the
    TARGET_AVX512VL subset, leading to problems when command line options
    enable AVX512 (i.e. AVX512F) but not the required AVX512VL functionality.
    The simple fix is to update/correct the target checks.

    2023-07-31  Roger Sayle  <roger@nextmovesoftware.com>

    gcc/ChangeLog
            PR target/110843
            * config/i386/i386-features.cc (compute_convert_gain): Check
            TARGET_AVX512VL (not TARGET_AVX512F) when considering V2DImode
            and V4SImode rotates in STV.
            (general_scalar_chain::convert_rotate): Likewise.

    gcc/testsuite/ChangeLog
            PR target/110843
            * gcc.target/i386/pr110843.c: New test case.

  parent reply	other threads:[~2023-07-31  7:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-28 12:07 [Bug target/110843] New: " jamborm at gcc dot gnu.org
2023-07-28 12:49 ` [Bug target/110843] " roger at nextmovesoftware dot com
2023-07-28 13:23 ` [Bug target/110843] [14 Regression] " rguenth at gcc dot gnu.org
2023-07-31  7:09 ` cvs-commit at gcc dot gnu.org [this message]
2023-07-31  8:09 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110843-4-OqxCVF88KD@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).