public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "matz at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/110899] RFE: Attributes preserve_most and preserve_all
Date: Mon, 07 Aug 2023 16:24:50 +0000	[thread overview]
Message-ID: <bug-110899-4-i741UOvQI0@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110899-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110899

--- Comment #9 from Michael Matz <matz at gcc dot gnu.org> ---
(In reply to Florian Weimer from comment #8)
> (In reply to Michael Matz from comment #7)
> > > > Does the clang implementation take into account the various problematic
> > > > cases that arise when calling a normal function from a (say) preserve_all
> > > > function
> > > > (hint: such call can't usually be done)?
> > > 
> > > How so? We need to version the __preserve_most__ attribute with the ISA
> > > level, of course.
> > 
> > I don't see how that helps.  Imagine a preserve_all function foo that calls
> > printf.  How do you propose that 'foo' saves all parts of the SSE registers,
> > even those that aren't invented yet, or those that can't be touched by the
> > current ISA?  (printf might clobber all of these)
> 
> Vector registers are out of scope for this.

Why do you say that?  From clang: "Furthermore it also preserves all
floating-point registers (XMMs/YMMs)."  (for preserve_all, but this bugreport
does
include that variant of the attribute).

> But lets look at APX. If printf is recompiled to use APX, then it will
> clobber the extended register file. If we define __preserve_most__ the way
> we do in my psABI proposal (i.e., *not* as everything but %r11), the
> extended APX registers are still caller-saved.

Right, for preserve_most _with your wording_ it works out.  preserve_all
or preserve_most with clang wording doesn't.

> (These details are the main reason why I want this in the psABI
> documentation. This stuff is out there and will be used, so let's make sure
> that it's somewhat reasonable.)

I agree with that.  I just want a little hashing-out-the-details before
putting anything in the psABI.

  parent reply	other threads:[~2023-08-07 16:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04 13:57 [Bug target/110899] New: " elver at google dot com
2023-08-04 14:19 ` [Bug target/110899] " pinskia at gcc dot gnu.org
2023-08-07  8:38 ` rguenth at gcc dot gnu.org
2023-08-07 12:28 ` fw at gcc dot gnu.org
2023-08-07 12:55 ` matz at gcc dot gnu.org
2023-08-07 12:59 ` matz at gcc dot gnu.org
2023-08-07 13:42 ` fw at gcc dot gnu.org
2023-08-07 13:55 ` hubicka at gcc dot gnu.org
2023-08-07 15:34 ` matz at gcc dot gnu.org
2023-08-07 16:19 ` fw at gcc dot gnu.org
2023-08-07 16:24 ` matz at gcc dot gnu.org [this message]
2023-08-08  8:59 ` fw at gcc dot gnu.org
2023-08-08 12:47 ` matz at gcc dot gnu.org
2023-12-25 11:04 ` sjames at gcc dot gnu.org
2023-12-28 21:26 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110899-4-i741UOvQI0@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).