public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "luoyonggang at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/110921] Relax _tzcnt_u32 support x86, all x86 arch support for this instrunction
Date: Mon, 07 Aug 2023 10:39:38 +0000 [thread overview]
Message-ID: <bug-110921-4-DGfXsIhyYr@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110921-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110921
--- Comment #8 from 罗勇刚(Yonggang Luo) <luoyonggang at gmail dot com> ---
(In reply to Hongtao.liu from comment #7)
> No, I think what clang does is correct,
Thanks, yeap, according to https://github.com/llvm/llvm-project/issues/64477
I think clang did it well.
GCC also needs handling the following code properly
```c
#ifdef _MSC_VER
#include <intrin.h>
__forceinline void
unreachable() {__assume(0);}
#else
#include <x86intrin.h>
inline __attribute__((always_inline)) void
unreachable() {
#if defined(__INTEL_COMPILER)
__assume(0);
#else
__builtin_unreachable();
#endif
}
#endif
int f(int a)
{
if (a == 0) {
unreachable();
}
return _tzcnt_u32 (a);
}
```
According to https://godbolt.org/z/T9axzaPqj
gcc with `-O2 -mbmi -m32` option compiled to
```asm
f(int):
xor eax, eax
tzcnt eax, DWORD PTR [esp+4]
ret
```
There is a redundant xor instrunction,
Without `-mbmi` option, gcc can not compile and all other three compiler
can compile.
This issue still make sense, gcc can fixes it in Clang's way
next prev parent reply other threads:[~2023-08-07 10:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-06 14:40 [Bug target/110921] New: " luoyonggang at gmail dot com
2023-08-06 17:32 ` [Bug target/110921] " pinskia at gcc dot gnu.org
2023-08-06 17:32 ` pinskia at gcc dot gnu.org
2023-08-07 1:27 ` crazylht at gmail dot com
2023-08-07 1:44 ` crazylht at gmail dot com
2023-08-07 1:52 ` crazylht at gmail dot com
2023-08-07 2:12 ` luoyonggang at gmail dot com
2023-08-07 2:46 ` crazylht at gmail dot com
2023-08-07 10:39 ` luoyonggang at gmail dot com [this message]
2023-08-07 11:50 ` crazylht at gmail dot com
2023-08-07 12:36 ` luoyonggang at gmail dot com
2023-08-07 12:59 ` crazylht at gmail dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-110921-4-DGfXsIhyYr@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).