public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "xry111 at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/110939] [14 Regression] 14.0 ICE at rtl.h:2297 while bootstrapping on loongarch64
Date: Mon, 02 Oct 2023 05:21:01 +0000	[thread overview]
Message-ID: <bug-110939-4-gLMlYsZiym@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110939-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110939

Xi Ruoyao <xry111 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
Fixed at r14-4355:

commit 86b2ffc0b8334c86ed13974f7d986821040474a4
Author: Stefan Schulze Frielinghaus <stefansf@linux.ibm.com>
Date:   Sun Oct 1 16:11:32 2023 +0200

    rtl-optimization/110939 Really fix narrow comparison of memory and constant

    In the former fix in commit 41ef5a34161356817807be3a2e51fbdbe575ae85 I
    completely missed the fact that the normal form of a CONST_INT for a
    mode with fewer bits than in HOST_WIDE_INT is a sign extended version of
    the actual constant.  This even holds true for unsigned constants.

    Fixed by masking out the upper bits for the incoming constant and sign
    extending the resulting unsigned constant.

    gcc/ChangeLog:

            * combine.cc (simplify_compare_const): Properly handle unsigned
            constants while narrowing comparison of memory and constants.

  parent reply	other threads:[~2023-10-02  5:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08  2:20 [Bug bootstrap/110939] New: " panchenghui at loongson dot cn
2023-08-08  2:25 ` [Bug rtl-optimization/110939] [14 Regression] " pinskia at gcc dot gnu.org
2023-08-08  8:27 ` rguenth at gcc dot gnu.org
2023-08-08  9:41 ` panchenghui at loongson dot cn
2023-08-08  9:41 ` xry111 at gcc dot gnu.org
2023-08-08 10:36 ` panchenghui at loongson dot cn
2023-08-08 10:37 ` xry111 at gcc dot gnu.org
2023-08-08 10:58 ` stefansf at linux dot ibm.com
2023-08-08 11:20 ` panchenghui at loongson dot cn
2023-08-08 11:21 ` panchenghui at loongson dot cn
2023-08-08 17:02 ` stefansf at linux dot ibm.com
2023-08-09  1:55 ` panchenghui at loongson dot cn
2023-08-11 14:28 ` stefansf at linux dot ibm.com
2023-08-24  0:45 ` xry111 at gcc dot gnu.org
2023-08-26  2:28 ` xry111 at gcc dot gnu.org
2023-08-26  2:28 ` xry111 at gcc dot gnu.org
2023-10-02  4:27 ` xry111 at gcc dot gnu.org
2023-10-02  5:21 ` xry111 at gcc dot gnu.org [this message]
2023-10-02  5:21 ` xry111 at gcc dot gnu.org
2023-10-02  5:22 ` xry111 at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110939-4-gLMlYsZiym@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).