public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/111048] [14 Regression] Wrong AVX2 code on highway-1.0.6 on -O2 and above Date: Fri, 18 Aug 2023 07:39:24 +0000 [thread overview] Message-ID: <bug-111048-4-x9FmtzvDcm@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-111048-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111048 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rsandifo at gcc dot gnu.org --- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> --- We somehow compute res_nelts to 12, coming via /* (1) If SEL is a suitable mask as determined by valid_mask_for_fold_vec_perm_cst_p, then: res_npatterns = max of npatterns between ARG0, ARG1, and SEL res_nelts_per_pattern = max of nelts_per_pattern between ARG0, ARG1 and SEL. (2) If SEL is not a suitable mask, and TYPE is VLS then: res_npatterns = nelts in result vector. res_nelts_per_pattern = 1. This exception is made so that VLS ARG0, ARG1 and SEL work as before. */ if (valid_mask_for_fold_vec_perm_cst_p (arg0, arg1, sel, reason)) { I suppose doing else if (TYPE_VECTOR_SUBPARTS (type).is_constant (&res_nelts)) first would fix this, but then the above looks wrong? I'm going to test & push the "obvious" to fix x86_64, but I suppose you should double-check your logic that goes wrong for non-VLA vectors.
next prev parent reply other threads:[~2023-08-18 7:39 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-17 11:40 [Bug target/111048] New: " slyfox at gcc dot gnu.org 2023-08-17 12:35 ` [Bug target/111048] " slyfox at gcc dot gnu.org 2023-08-17 18:32 ` [Bug middle-end/111048] " pinskia at gcc dot gnu.org 2023-08-17 18:39 ` [Bug tree-optimization/111048] " pinskia at gcc dot gnu.org 2023-08-18 7:39 ` rguenth at gcc dot gnu.org [this message] 2023-08-18 8:24 ` cvs-commit at gcc dot gnu.org 2023-08-18 8:25 ` rguenth at gcc dot gnu.org 2023-08-18 9:08 ` prathamesh3492 at gcc dot gnu.org 2023-08-18 9:35 ` rsandifo at gcc dot gnu.org 2023-08-18 14:27 ` [Bug tree-optimization/111048] [14 Regression] Wrong AVX2 code on highway-1.0.6 on -O2 and above since r14-3243-ga7dba4a1c05a76 prathamesh3492 at gcc dot gnu.org 2023-08-21 9:57 ` cvs-commit at gcc dot gnu.org 2023-08-21 11:04 ` prathamesh3492 at gcc dot gnu.org 2023-08-21 17:49 ` slyfox at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-111048-4-x9FmtzvDcm@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).