[Bug sanitizer/111057] New: build error: libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:180:10: fatal error: crypt.h: No such file or directory

[Bug sanitizer/111057] New: build error: libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:180:10: fatal error: crypt.h: No such file or directory

[judge.packham at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111057

            Bug ID: 111057
           Summary: build error:
                    libsanitizer/sanitizer_common/sanitizer_platform_limit
                    s_posix.cpp:180:10: fatal error: crypt.h: No such file
                    or directory
           Product: gcc
           Version: 13.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: judge.packham at gmail dot com
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org, marxin at gcc dot gnu.org
  Target Milestone: ---

Hi from crosstool-ng,

I've had a user report a build error for GCC 13.2.0 with and aarch64 config
with libsanitizer enabled
(https://github.com/crosstool-ng/crosstool-ng/issues/2010).

[ERROR]   
/home/ctng/crosstool-ng/.build/aarch64-unknown-linux-gnu/src/gcc/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:180:10:
fatal error: crypt.h: No such file or directory
[ALL  ]      180 | #include <crypt.h>
[ALL  ]          |          ^~~~~~~~~
[ALL  ]    compilation terminated.
[ERROR]    make[5]: *** [Makefile:614: sanitizer_platform_limits_posix.lo]
Error 1
[ERROR]    make[5]: *** Waiting for unfinished jobs....

It looks like this may have already been fixed in master by commit d96e14ceb947
("libsanitizer: merge from upstream (87e6e490e79384a5)"). Is that the kind of
thing that might end up in the 13.x branch? Alternatively is there a lower
impact change that might be back-ported?

Thanks,
Chris

[Bug sanitizer/111057] build error: libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:180:10: fatal error: crypt.h: No such file or directory

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111057

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
What version of glibc is being built with here?

[Bug sanitizer/111057] build error: libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:180:10: fatal error: crypt.h: No such file or directory

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111057

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Most likely could backport:

https://github.com/llvm/llvm-project/commit/d7bead833631486e337e541e692d9b4a1ca14edd

[Bug sanitizer/111057] [11/12/13 only] build error: libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:180:10: fatal error: crypt.h: No such file or directory

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111057

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|build error:                |[11/12/13 only] build
                   |libsanitizer/sanitizer_comm |error:
                   |on/sanitizer_platform_limit |libsanitizer/sanitizer_comm
                   |s_posix.cpp:180:10: fatal   |on/sanitizer_platform_limit
                   |error: crypt.h: No such     |s_posix.cpp:180:10: fatal
                   |file or directory           |error: crypt.h: No such
                   |                            |file or directory
      Known to work|                            |14.0
   Target Milestone|---                         |11.5

[Bug sanitizer/111057] [11/12/13 only] build error: libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:180:10: fatal error: crypt.h: No such file or directory

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111057

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-08-18
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
.

[Bug sanitizer/111057] [11/12/13 only] build error: libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:180:10: fatal error: crypt.h: No such file or directory

[judge.packham at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111057

--- Comment #4 from Chris Packham <judge.packham at gmail dot com> ---
(In reply to Andrew Pinski from comment #1)
> What version of glibc is being built with here?

glibc-2.38


> Most likely could backport:
>
> https://github.com/llvm/llvm-project/commit/d7bead833631486e337e541e692d9b4a1ca14edd

Yes looks as though that'd do it. I'll try and whip that up for ct-ng to carry.
Do you want me to try for a proper GCC patch as well?

[Bug sanitizer/111057] [11/12/13 only] build error: libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:180:10: fatal error: crypt.h: No such file or directory

[judge.packham at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111057

--- Comment #5 from Chris Packham <judge.packham at gmail dot com> ---
Created attachment 55751
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55751&action=edit
Remove crypt and crypt_r interceptors

Attached is the patch derived from
https://github.com/llvm/llvm-project/commit/d7bead833631486e337e541e692d9b4a1ca14edd
which we'll be carrying in crosstool-ng. I've kept the upstream authors and
commit message.

It should apply cleanly to the releases/gcc-13 branch but is not necessary for
14.x.

[Bug sanitizer/111057] [11/12/13 only] build error: libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:180:10: fatal error: crypt.h: No such file or directory

[romain.geissler at amadeus dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111057

Romain Geissler <romain.geissler at amadeus dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |romain.geissler at amadeus dot com

--- Comment #6 from Romain Geissler <romain.geissler at amadeus dot com> ---
@Chris the gcc maintainers don't really review patches send in bug reports,
they expect it to be sent on the mailing list (gcc-patches@gcc.gnu.org). Do you
want to post it there so this gets integrated ?