public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/111071] New: gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp has new failures since commit e7a36e4715c7
@ 2023-08-19 3:08 thiago.bauermann at linaro dot org
2023-08-19 3:09 ` [Bug target/111071] " thiago.bauermann at linaro dot org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: thiago.bauermann at linaro dot org @ 2023-08-19 3:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111071
Bug ID: 111071
Summary: gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp
has new failures since commit e7a36e4715c7
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: thiago.bauermann at linaro dot org
CC: yanzhang.wang at intel dot com
Target Milestone: ---
Created attachment 55760
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55760&action=edit
gcc.log from trunk as of commit 4acbb51d7f28
Our CI detected that commit e7a36e4715c7 "[PATCH] RISC-V: Support simplify
(-1-x) for vector." introduced these testsuite failures on aarch64-linux:
=== g++ tests ===
Running g++:g++.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp ...
FAIL: gcc.target/aarch64/sve/acle/asm/subr_s8.c -std=gnu++98 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_FULL check-function-bodies
subr_m1_s8_m
FAIL: gcc.target/aarch64/sve/acle/asm/subr_s8.c -std=gnu++98 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_OVERLOADS
check-function-bodies subr_m1_s8_m
FAIL: gcc.target/aarch64/sve/acle/asm/subr_u8.c -std=gnu++98 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_FULL check-function-bodies
subr_m1_u8_m
FAIL: gcc.target/aarch64/sve/acle/asm/subr_u8.c -std=gnu++98 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_OVERLOADS
check-function-bodies subr_m1_u8_m
=== gcc tests ===
Running gcc:gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp ...
FAIL: gcc.target/aarch64/sve/acle/asm/subr_s8.c -std=gnu90 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_FULL check-function-bodies
subr_m1_s8_m
FAIL: gcc.target/aarch64/sve/acle/asm/subr_s8.c -std=gnu90 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_OVERLOADS
check-function-bodies subr_m1_s8_m
FAIL: gcc.target/aarch64/sve/acle/asm/subr_u8.c -std=gnu90 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_FULL check-function-bodies
subr_m1_u8_m
FAIL: gcc.target/aarch64/sve/acle/asm/subr_u8.c -std=gnu90 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_OVERLOADS
check-function-bodies subr_m1_u8_m
I confirmed that they are still present in trunk as of commit 4acbb51d7f28
"Daily bump." from today.
Tested on Ubuntu 22.04 with:
$ ~/src/gcc/configure \
--disable-bootstrap \
--disable-multilib \
&& make -j 60 \
&& make -C gcc check-gcc
RUNTESTFLAGS=gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp
I'll attach gcc.log from trunk as well as from the parent of commit
e7a36e4715c7, which was the last commit where the test passed.
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug target/111071] gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp has new failures since commit e7a36e4715c7
2023-08-19 3:08 [Bug target/111071] New: gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp has new failures since commit e7a36e4715c7 thiago.bauermann at linaro dot org
@ 2023-08-19 3:09 ` thiago.bauermann at linaro dot org
2023-08-19 3:18 ` [Bug testsuite/111071] [14 Regression] " pinskia at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: thiago.bauermann at linaro dot org @ 2023-08-19 3:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111071
--- Comment #1 from Thiago Jung Bauermann <thiago.bauermann at linaro dot org> ---
Created attachment 55761
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55761&action=edit
gcc.log from commit a32de58c9e63, parent of e7a36e4715c
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug testsuite/111071] [14 Regression] gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp has new failures since commit e7a36e4715c7
2023-08-19 3:08 [Bug target/111071] New: gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp has new failures since commit e7a36e4715c7 thiago.bauermann at linaro dot org
2023-08-19 3:09 ` [Bug target/111071] " thiago.bauermann at linaro dot org
@ 2023-08-19 3:18 ` pinskia at gcc dot gnu.org
2023-09-04 18:57 ` cvs-commit at gcc dot gnu.org
2023-09-11 23:07 ` thiago.bauermann at linaro dot org
3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-08-19 3:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111071
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |testsuite-fail
Version|unknown |14.0
Ever confirmed|0 |1
Target Milestone|--- |14.0
Status|UNCONFIRMED |NEW
Summary|gcc.target/aarch64/sve/acle |[14 Regression]
|/aarch64-sve-acle-asm.exp |gcc.target/aarch64/sve/acle
|has new failures since |/aarch64-sve-acle-asm.exp
|commit e7a36e4715c7 |has new failures since
| |commit e7a36e4715c7
Component|target |testsuite
Last reconfirmed| |2023-08-19
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.
The code is better:
For subr_m1_s8_m, GCC now produces:
not z0.b, p0/m, z0.b
ret
Rather than what was originally expected:
/*
** subr_m1_s8_m:
** mov (z[0-9]+\.b), #-1
** subr z0\.b, p0/m, z0\.b, \1
** ret
*/
So just a testsuite update is needed here.
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug testsuite/111071] [14 Regression] gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp has new failures since commit e7a36e4715c7
2023-08-19 3:08 [Bug target/111071] New: gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp has new failures since commit e7a36e4715c7 thiago.bauermann at linaro dot org
2023-08-19 3:09 ` [Bug target/111071] " thiago.bauermann at linaro dot org
2023-08-19 3:18 ` [Bug testsuite/111071] [14 Regression] " pinskia at gcc dot gnu.org
@ 2023-09-04 18:57 ` cvs-commit at gcc dot gnu.org
2023-09-11 23:07 ` thiago.bauermann at linaro dot org
3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-09-04 18:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111071
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.org>:
https://gcc.gnu.org/g:a338c5f6114f3b9f2ed067bc7738b405091a76ce
commit r14-3658-ga338c5f6114f3b9f2ed067bc7738b405091a76ce
Author: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Date: Mon Sep 4 19:57:10 2023 +0100
testsuite: aarch64: Adjust SVE ACLE tests to new generated code
Since commit e7a36e4715c7 "[PATCH] RISC-V: Support simplify (-1-x) for
vector." these tests fail on aarch64-linux:
=== g++ tests ===
Running g++:g++.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp ...
FAIL: gcc.target/aarch64/sve/acle/asm/subr_s8.c -std=gnu++98 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_FULL check-function-bodies
subr_m1_s8_m
FAIL: gcc.target/aarch64/sve/acle/asm/subr_s8.c -std=gnu++98 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_OVERLOADS
check-function-bodies subr_m1_s8_m
FAIL: gcc.target/aarch64/sve/acle/asm/subr_u8.c -std=gnu++98 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_FULL check-function-bodies
subr_m1_u8_m
FAIL: gcc.target/aarch64/sve/acle/asm/subr_u8.c -std=gnu++98 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_OVERLOADS
check-function-bodies subr_m1_u8_m
=== gcc tests ===
Running gcc:gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp ...
FAIL: gcc.target/aarch64/sve/acle/asm/subr_s8.c -std=gnu90 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_FULL check-function-bodies
subr_m1_s8_m
FAIL: gcc.target/aarch64/sve/acle/asm/subr_s8.c -std=gnu90 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_OVERLOADS
check-function-bodies subr_m1_s8_m
FAIL: gcc.target/aarch64/sve/acle/asm/subr_u8.c -std=gnu90 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_FULL check-function-bodies
subr_m1_u8_m
FAIL: gcc.target/aarch64/sve/acle/asm/subr_u8.c -std=gnu90 -O2
-fno-schedule-insns -DCHECK_ASM --save-temps -DTEST_OVERLOADS
check-function-bodies subr_m1_u8_m
Andrew Pinski's analysis in PR testsuite/111071 is that the new code is
better and the testcase should be updated. I also asked Prathamesh Kulkarni
in private and he agreed.
Here is the update. With this change, all tests in
gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp pass on aarch64-linux.
Suggested-by: Andrew Pinski <apinski@marvell.com>
gcc/testsuite/
PR testsuite/111071
* gcc.target/aarch64/sve/acle/asm/subr_s8.c: Adjust to new code.
* gcc.target/aarch64/sve/acle/asm/subr_u8.c: Likewise.
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug testsuite/111071] [14 Regression] gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp has new failures since commit e7a36e4715c7
2023-08-19 3:08 [Bug target/111071] New: gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp has new failures since commit e7a36e4715c7 thiago.bauermann at linaro dot org
` (2 preceding siblings ...)
2023-09-04 18:57 ` cvs-commit at gcc dot gnu.org
@ 2023-09-11 23:07 ` thiago.bauermann at linaro dot org
3 siblings, 0 replies; 5+ messages in thread
From: thiago.bauermann at linaro dot org @ 2023-09-11 23:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111071
Thiago Jung Bauermann <thiago.bauermann at linaro dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from Thiago Jung Bauermann <thiago.bauermann at linaro dot org> ---
Closing.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-09-11 23:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-19 3:08 [Bug target/111071] New: gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp has new failures since commit e7a36e4715c7 thiago.bauermann at linaro dot org
2023-08-19 3:09 ` [Bug target/111071] " thiago.bauermann at linaro dot org
2023-08-19 3:18 ` [Bug testsuite/111071] [14 Regression] " pinskia at gcc dot gnu.org
2023-09-04 18:57 ` cvs-commit at gcc dot gnu.org
2023-09-11 23:07 ` thiago.bauermann at linaro dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).