public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "adam.f.badura at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/111087] -Wnonnull issued for std::array of zero size when under C++20
Date: Mon, 21 Aug 2023 07:31:34 +0000	[thread overview]
Message-ID: <bug-111087-4-ZnmIhf6R9l@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111087-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111087

--- Comment #5 from Adam Badura <adam.f.badura at gmail dot com> ---
(In reply to Andrew Pinski from comment #3)
> The warning is correct as tags.end() and tags.begin() will always be a
> nullptr for std::array<T, 0>

Yes. But what does it change?

`std::lower_bound` gets an empty range (begin == end) and hence will return the
`end` value. Then we check `result != tags.end()` which should cut off since it
will be false and hence we will never reach the place where we use
`result->`...

Let me add, that the issue is not about short-circuiting since it also shows in
the elaborate form:

  if (result != tags.end())
  {
    return result->compare(tag) == 0;
  }
  else
  {
    return false;
  }

  parent reply	other threads:[~2023-08-21  7:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21  6:29 [Bug c++/111087] New: " adam.f.badura at gmail dot com
2023-08-21  6:33 ` [Bug c++/111087] " pinskia at gcc dot gnu.org
2023-08-21  6:53 ` adam.f.badura at gmail dot com
2023-08-21  7:26 ` pinskia at gcc dot gnu.org
2023-08-21  7:27 ` pinskia at gcc dot gnu.org
2023-08-21  7:31 ` adam.f.badura at gmail dot com [this message]
2023-08-21  7:39 ` pinskia at gcc dot gnu.org
2023-08-21  7:47 ` adam.f.badura at gmail dot com
2023-08-21  7:54 ` pinskia at gcc dot gnu.org
2023-08-21  8:03 ` adam.f.badura at gmail dot com
2023-08-21 10:31 ` redi at gcc dot gnu.org
2023-08-21 10:36 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111087-4-ZnmIhf6R9l@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).