From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id B0D493858415; Wed, 29 Nov 2023 03:54:39 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B0D493858415
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1701230079;
	bh=U3lbqbpHH8rmGH9q498NBkZ52u1tMwjKZ5NlRNnIC80=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=LLMyuYlda7My5Zr/W2b1MQAakMJ/7HF5qKE6chE0EzMLzi/zOte8oW93ju/UPSk6u
	 Ti5aP9llYgKXpeXUdm3fv07qg5kL6C5P8/roqXCn66eTCkPD5Lugj6eiE9DFPS+w7Z
	 ugKvpOCoG1cQQbyc4kN+SyzSnShdMyzcTZx7nQUU=
From: "zfigura at codeweavers dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/111107] i686-w64-mingw32 does not realign stack when
 __attribute__((aligned)) or __attribute__((vector_size)) are used
Date: Wed, 29 Nov 2023 03:54:37 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 12.2.0
X-Bugzilla-Keywords: ABI, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: zfigura at codeweavers dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-111107-4-2Ejjo8cp8f@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-111107-4@http.gcc.gnu.org/bugzilla/>
References: <bug-111107-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D111107

--- Comment #15 from Zeb Figura <zfigura at codeweavers dot com> ---
(In reply to Eric Botcazou from comment #14)
> > I'd say that
> >=20
> > config/i386/cygming.h:#define STACK_REALIGN_DEFAULT TARGET_SSE
> >=20
> > is a non-working "fix".  The appropriate default would be
> > -mincoming-stack-boundary=3D2.  MIN_STACK_BOUNDARY should already be 4,=
 so
> > that leaves PREFERRED_STACK_BOUNDARY_DEFAULT is the way to go here.
>=20
> This was a minimal fix to support SSE, but Solaris was indeed more radica=
l:
>=20
> sol2.h:#undef STACK_REALIGN_DEFAULT
> sol2.h:#define STACK_REALIGN_DEFAULT (TARGET_64BIT ? 0 : 1)
>=20
> so we could just mimic it for Windows.

Why use STACK_REALIGN_DEFAULT rather than PREFERRED_STACK_BOUNDARY_DEFAULT?=