public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/111156] [14 Regression] aarch64 aarch64/sve/mask_struct_store_4.c failures Date: Fri, 16 Feb 2024 13:19:08 +0000 [thread overview] Message-ID: <bug-111156-4-PnWjExZIkk@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-111156-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111156 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rsandifo at gcc dot gnu.org --- Comment #23 from Richard Biener <rguenth at gcc dot gnu.org> --- (In reply to Richard Biener from comment #18) > diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc > index 7cf9504398c..8deeecfd4aa 100644 > --- a/gcc/tree-vect-slp.cc > +++ b/gcc/tree-vect-slp.cc > @@ -1280,8 +1280,11 @@ vect_build_slp_tree_1 (vec_info *vinfo, unsigned char > *swap, > && rhs_code.is_tree_code () > && (TREE_CODE_CLASS (tree_code (first_stmt_code)) > == tcc_comparison) > - && (swap_tree_comparison (tree_code (first_stmt_code)) > - == tree_code (rhs_code))) > + && ((swap_tree_comparison (tree_code (first_stmt_code)) > + == tree_code (rhs_code)) > + || ((TREE_CODE_CLASS (tree_code (alt_stmt_code)) > + == tcc_comparison) > + && rhs_code == alt_stmt_code))) > && !(STMT_VINFO_GROUPED_ACCESS (stmt_info) > && (first_stmt_code == ARRAY_REF > || first_stmt_code == BIT_FIELD_REF > diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index 7cf9504398c..e35eeeea3fa 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -1519,7 +1522,9 @@ vect_build_slp_tree_1 (vec_info *vinfo, unsigned char *swap, if (alt_stmt_code != ERROR_MARK && (!alt_stmt_code.is_tree_code () || (TREE_CODE_CLASS (tree_code (alt_stmt_code)) != tcc_reference - && TREE_CODE_CLASS (tree_code (alt_stmt_code)) != tcc_comparison))) + && (TREE_CODE_CLASS (tree_code (alt_stmt_code)) != tcc_comparison + || (swap_tree_comparison (tree_code (first_stmt_code)) + != tree_code (alt_stmt_code)))))) { *two_operators = true; } is also needed btw. to avoid wrong-code. I see t.c:8:26: note: ==> examining statement: pretmp_29 = *_28; t.c:8:26: missed: unsupported load permutation t.c:10:30: missed: not vectorized: relevant stmt not supported: pretmp_29 = *_28; t.c:8:26: note: removing SLP instance operations starting from: .MASK_STORE (_5, 8B, patt_12, pretmp_29); using -O3 -march=armv8.3-a+sve - it then does t.c:8:26: missed: unsupported SLP instances t.c:8:26: note: re-trying with SLP disabled and _that_ fails then with t.c:8:26: missed: Not using elementwise accesses due to variable vectorization factor. t.c:6:1: missed: not vectorized: relevant stmt not supported: .MASK_STORE (_5, 8B, patt_12, pretmp_29); but the interesting bit is why it fails to handle the SLP case. That's possibly because the load isn't a grouped access, we get dr_group_size == 1 and group_size == 2 and nunits is {16, 16} (!repeating_p) and so /* We need to construct a separate mask for each vector statement. */ unsigned HOST_WIDE_INT const_nunits, const_vf; if (!nunits.is_constant (&const_nunits) || !vf.is_constant (&const_vf)) return false; I'm not sure what that comment means, but supposedly we simply fail to handle another special case that we could here? Possibly dr_group_size == 1?
prev parent reply other threads:[~2024-02-16 13:19 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-25 13:35 [Bug middle-end/111156] New: " adhemerval.zanella at linaro dot org 2023-08-25 18:02 ` [Bug middle-end/111156] " dcb314 at hotmail dot com 2023-08-25 18:12 ` dcb314 at hotmail dot com 2023-08-25 18:15 ` dcb314 at hotmail dot com 2023-08-28 7:13 ` rguenth at gcc dot gnu.org 2023-08-31 17:25 ` adhemerval.zanella at linaro dot org 2023-11-24 0:45 ` pinskia at gcc dot gnu.org 2024-01-15 13:52 ` rguenth at gcc dot gnu.org 2024-02-01 10:15 ` tnfchris at gcc dot gnu.org 2024-02-02 3:31 ` pinskia at gcc dot gnu.org 2024-02-02 3:51 ` pinskia at gcc dot gnu.org 2024-02-02 20:10 ` pinskia at gcc dot gnu.org 2024-02-02 20:26 ` pinskia at gcc dot gnu.org 2024-02-14 20:11 ` tnfchris at gcc dot gnu.org 2024-02-15 8:34 ` rguenth at gcc dot gnu.org 2024-02-15 8:39 ` tnfchris at gcc dot gnu.org 2024-02-15 8:41 ` tnfchris at gcc dot gnu.org 2024-02-15 10:57 ` rguenth at gcc dot gnu.org 2024-02-15 12:41 ` rguenth at gcc dot gnu.org 2024-02-15 13:02 ` rguenth at gcc dot gnu.org 2024-02-15 14:38 ` cvs-commit at gcc dot gnu.org 2024-02-15 14:39 ` rguenth at gcc dot gnu.org 2024-02-15 18:53 ` tnfchris at gcc dot gnu.org 2024-02-15 21:05 ` rguenther at suse dot de 2024-02-16 13:19 ` rguenth at gcc dot gnu.org [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-111156-4-PnWjExZIkk@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).