public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/111156] [14 Regression] aarch64 aarch64/sve/mask_struct_store_4.c failures
Date: Thu, 15 Feb 2024 10:57:18 +0000	[thread overview]
Message-ID: <bug-111156-4-ps9oW8GZwy@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111156-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111156

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #16 from Richard Biener <rguenth at gcc dot gnu.org> ---
OK, so the missed SLP is a known one:

t.c:8:26: note:   starting SLP discovery for node 0x5d42840
t.c:8:26: note:   Build SLP for _27 = _3 <= 7;
t.c:8:26: note:   precomputed vectype: vector([8,8]) <signed-boolean:2>
t.c:8:26: note:   nunits = [8,8]
t.c:8:26: note:   Build SLP for _14 = _3 > 2;
t.c:8:26: note:   precomputed vectype: vector([8,8]) <signed-boolean:2>
t.c:8:26: note:   nunits = [8,8]
t.c:8:26: missed:   Build SLP failed: different operation in stmt _14 = _3 > 2;
t.c:8:26: missed:   original stmt _27 = _3 <= 7;

I'm not sure we can do this with a single vector stmt but of course using
'two_operator' support might be possible here (do both > and <= and then
blend the result).

I see we end up using .MASK_STORE_LANES in the end but we're not using
load-lanes.

t.c:8:26: note:   ==> examining pattern statement: .MASK_STORE (_5, 8B,
patt_12, pretmp_29);
t.c:8:26: note:   vect_is_simple_use: operand (<signed-boolean:1>) _27, type of
def: internal
t.c:8:26: note:   vect_is_simple_use: vectype vector([16,16])
<signed-boolean:1>
t.c:8:26: note:   vect_is_simple_use: operand *_28, type of def: internal
t.c:8:26: note:   vect_is_simple_use: vectype vector([16,16]) signed char
t.c:8:26: missed:   cannot use vec_mask_len_store_lanes<VNx32QI><VNx16QI>
t.c:8:26: note:   can use vec_mask_store_lanes<VNx32QI><VNx16QI>
t.c:8:26: note:   vect_is_simple_use: operand *_28, type of def: internal
t.c:8:26: missed:   cannot use vec_mask_len_store_lanes<VNx32QI><VNx16QI>
t.c:8:26: note:   can use vec_mask_store_lanes<VNx32QI><VNx16QI>
...
t.c:8:26: note:   ==> examining pattern statement: .MASK_STORE (_9, 8B, patt_4,
pretmp_29);
t.c:8:26: note:   vect_is_simple_use: operand (<signed-boolean:1>) _14, type of
def: internal
t.c:8:26: note:   vect_is_simple_use: vectype vector([16,16])
<signed-boolean:1>
t.c:8:26: note:   vect_is_simple_use: operand *_28, type of def: internal
t.c:8:26: note:   vect_is_simple_use: vectype vector([16,16]) signed char
t.c:8:26: missed:   cannot use vec_mask_len_store_lanes<VNx32QI><VNx16QI>
t.c:8:26: note:   can use vec_mask_store_lanes<VNx32QI><VNx16QI>
t.c:8:26: missed:   cannot use vec_mask_len_store_lanes<VNx32QI><VNx16QI>
t.c:8:26: note:   can use vec_mask_store_lanes<VNx32QI><VNx16QI>

and somehow transform decides to put the two stores together again, probably
missing to verify the masks are the same.

I'll dig a bit more after lunch.

  parent reply	other threads:[~2024-02-15 10:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25 13:35 [Bug middle-end/111156] New: " adhemerval.zanella at linaro dot org
2023-08-25 18:02 ` [Bug middle-end/111156] " dcb314 at hotmail dot com
2023-08-25 18:12 ` dcb314 at hotmail dot com
2023-08-25 18:15 ` dcb314 at hotmail dot com
2023-08-28  7:13 ` rguenth at gcc dot gnu.org
2023-08-31 17:25 ` adhemerval.zanella at linaro dot org
2023-11-24  0:45 ` pinskia at gcc dot gnu.org
2024-01-15 13:52 ` rguenth at gcc dot gnu.org
2024-02-01 10:15 ` tnfchris at gcc dot gnu.org
2024-02-02  3:31 ` pinskia at gcc dot gnu.org
2024-02-02  3:51 ` pinskia at gcc dot gnu.org
2024-02-02 20:10 ` pinskia at gcc dot gnu.org
2024-02-02 20:26 ` pinskia at gcc dot gnu.org
2024-02-14 20:11 ` tnfchris at gcc dot gnu.org
2024-02-15  8:34 ` rguenth at gcc dot gnu.org
2024-02-15  8:39 ` tnfchris at gcc dot gnu.org
2024-02-15  8:41 ` tnfchris at gcc dot gnu.org
2024-02-15 10:57 ` rguenth at gcc dot gnu.org [this message]
2024-02-15 12:41 ` rguenth at gcc dot gnu.org
2024-02-15 13:02 ` rguenth at gcc dot gnu.org
2024-02-15 14:38 ` cvs-commit at gcc dot gnu.org
2024-02-15 14:39 ` rguenth at gcc dot gnu.org
2024-02-15 18:53 ` tnfchris at gcc dot gnu.org
2024-02-15 21:05 ` rguenther at suse dot de
2024-02-16 13:19 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111156-4-ps9oW8GZwy@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).