public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/111217] New: variant of cond-bool-2.c fails
Date: Mon, 28 Aug 2023 19:25:47 +0000	[thread overview]
Message-ID: <bug-111217-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111217

            Bug ID: 111217
           Summary: variant of cond-bool-2.c fails
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---

Take:
```
static inline _Bool nand(_Bool a, _Bool b)
{
  _Bool t = 0;
  if (a) { if (b) t = 1; }
  return !t;
  //  return !(a && b);
}

_Bool f(int a, int b)
{
    return nand(nand(b, nand(a, a)), nand(a, nand(b, b)));
}
```

we get at ifcombine:
  <bb 2> [local count: 1073741824]:
  if (a_3(D) != 0)
    goto <bb 3>; [50.00%]
  else
    goto <bb 4>; [50.00%]

  <bb 3> [local count: 536870912]:
  if (b_2(D) != 0)
    goto <bb 6>; [50.00%]
  else
    goto <bb 5>; [50.00%]

  <bb 4> [local count: 536870912]:
  if (b_2(D) != 0)
    goto <bb 6>; [50.00%]
  else
    goto <bb 5>; [50.00%]

  <bb 5> [local count: 536870912]:
  ...

  <bb 6> [local count: 536870912]:
  # iftmp.0_21 = PHI <1(3), 0(4)>

So we could swap these ifs around slighlty

 if (b_2(D) != 0) goto L1; else goto L2;
L1:
 if (a_3(D) != 0) goto L3; else goto L4;
L3: goto L4;
L4:
 iftmp.0_21 = PHI <1(3), 0(4)>
L1: goto bb5;

And then it will be optimized.

             reply	other threads:[~2023-08-28 19:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28 19:25 pinskia at gcc dot gnu.org [this message]
2023-08-28 19:32 ` [Bug tree-optimization/111217] " cvs-commit at gcc dot gnu.org
2023-09-17  8:53 ` pinskia at gcc dot gnu.org
2023-09-17  8:57 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111217-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).