public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "luke.geeson at cs dot ucl.ac.uk" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/111235] [Armv7-a]: Control-dependency between atomic accesses removed by -O1. Date: Wed, 25 Oct 2023 16:10:20 +0000 [thread overview] Message-ID: <bug-111235-4-2MWCDT2PRv@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-111235-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111235 --- Comment #5 from Luke Geeson <luke.geeson at cs dot ucl.ac.uk> --- Thank you for fixing this, Wilco! I will now test this bug using the code emitted by Godbolt. Consider again the same source program. When run through gcc with the same flags we get the ARM assembly test: ``` ARM test { [P0_r0]=0;[P1_r0]=0;[x]=0;[y]=0; %P0_P0_r0=P0_r0;%P0_x=x;%P0_y=y; %P1_P1_r0=P1_r0;%P1_x=x;%P1_y=y } (*****************************************************************) (* the Telechat toolsuite *) (* *) (* Luke Geeson, University College London, UK. *) (* gcc -O1 -march=armv7-a -pthread --std=c11 -marm -fno-section-anchors*) (* *) (*****************************************************************) P0 | P1 ; LDR R2,[%P0_x] | LDR R2,[%P1_y] ; CMP R2,#1 | DMB ISH ; BEQ L3 | MOV R1,#1 ; L2: STR R2, [%P0_P0_r0]| STR R1, [%P1_x] ; BX LR | STR R2, [%P1_P1_r0] ; L3: MOV R1, #1 | ; STR R1, [%P0_y] | ; B L2 | ; exists (P0_r0=1 /\ P1_r0=1) ``` Which under the arm model has the outcomes: ``` [P0_r0]=0; [P1_r0]=0; [P0_r0]=1; [P1_r0]=0; ``` As you can see the buggy behaviour has gone away, the bug is fixed.
next prev parent reply other threads:[~2023-10-25 16:10 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-30 9:42 [Bug translation/111235] New: " luke.geeson at cs dot ucl.ac.uk 2023-08-30 9:42 ` [Bug translation/111235] " luke.geeson at cs dot ucl.ac.uk 2023-10-02 15:07 ` [Bug target/111235] " cvs-commit at gcc dot gnu.org 2023-10-02 15:39 ` sjames at gcc dot gnu.org 2023-10-03 13:19 ` luke.geeson at cs dot ucl.ac.uk 2023-10-25 16:10 ` luke.geeson at cs dot ucl.ac.uk [this message] 2023-10-31 16:42 ` wilco at gcc dot gnu.org 2023-10-31 16:48 ` sjames at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-111235-4-2MWCDT2PRv@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).