public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "roger at nextmovesoftware dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/111267] [14 Regression] Codegen regression from i386 argument passing changes Date: Sun, 14 Jan 2024 00:09:08 +0000 [thread overview] Message-ID: <bug-111267-4-7x5MLlaY4y@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-111267-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111267 --- Comment #7 from Roger Sayle <roger at nextmovesoftware dot com> --- Very many thanks to Jeff Law for pointing me to fwprop. The following simple patch also fixes this regression. diff --git a/gcc/fwprop.cc b/gcc/fwprop.cc index 0c588f8..cbba44e 100644 --- a/gcc/fwprop.cc +++ b/gcc/fwprop.cc @@ -449,15 +449,6 @@ try_fwprop_subst_pattern (obstack_watermark &attempt, insn_ change &use_change, if (prop.num_replacements == 0) return false; - if (!prop.profitable_p ()) - { - if (dump_file && (dump_flags & TDF_DETAILS)) - fprintf (dump_file, "cannot propagate from insn %d into" - " insn %d: %s\n", def_insn->uid (), use_insn->uid (), - "would increase complexity of pattern"); - return false; - } - if (dump_file && (dump_flags & TDF_DETAILS)) { fprintf (dump_file, "\npropagating insn %d into insn %d, replacing:\n",
next prev parent reply other threads:[~2024-01-14 0:09 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-01 12:55 [Bug rtl-optimization/111267] New: " manolis.tsamis at vrull dot eu 2023-09-12 10:43 ` [Bug rtl-optimization/111267] [14 Regression] " rguenth at gcc dot gnu.org 2023-10-17 12:34 ` rguenth at gcc dot gnu.org 2023-10-20 22:42 ` roger at nextmovesoftware dot com 2023-10-20 22:49 ` roger at nextmovesoftware dot com 2024-01-05 10:43 ` jakub at gcc dot gnu.org 2024-01-12 15:49 ` jakub at gcc dot gnu.org 2024-01-12 19:06 ` roger at nextmovesoftware dot com 2024-01-14 0:09 ` roger at nextmovesoftware dot com [this message] 2024-01-14 12:10 ` roger at nextmovesoftware dot com 2024-01-15 7:32 ` rguenth at gcc dot gnu.org 2024-01-16 1:15 ` roger at nextmovesoftware dot com 2024-01-21 21:25 ` cvs-commit at gcc dot gnu.org 2024-01-22 9:11 ` rsandifo at gcc dot gnu.org 2024-01-25 7:51 ` mkuvyrkov at gcc dot gnu.org 2024-01-25 7:55 ` clyon at gcc dot gnu.org 2024-01-25 9:48 ` mkuvyrkov at gcc dot gnu.org 2024-02-16 9:12 ` roger at nextmovesoftware dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-111267-4-7x5MLlaY4y@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).