public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/111283] [14 Regression] gnat profilebootstrap broken on trunk 20230902 on 32bit targets
Date: Thu, 05 Oct 2023 16:14:51 +0000	[thread overview]
Message-ID: <bug-111283-4-Jzeq18RFBl@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111283-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Sergei Trofimovich <slyfox@gcc.gnu.org>:

https://gcc.gnu.org/g:043a6fcbc27f8721301eb2f72a7839f54f393003

commit r14-4421-g043a6fcbc27f8721301eb2f72a7839f54f393003
Author: Sergei Trofimovich <siarheit@google.com>
Date:   Wed Sep 27 14:29:12 2023 +0100

    ipa-utils: avoid uninitialized probabilities on ICF [PR111559]

    r14-3459-g0c78240fd7d519 "Check that passes do not forget to define
profile"
    exposed check failures in cases when gcc produces uninitialized profile
    probabilities. In case of PR/111559 uninitialized profile is generated
    by edges executed 0 times reported by IPA profile:

        $ gcc -O2 -fprofile-generate pr111559.c -o b -fopt-info
        $ ./b
        $ gcc -O2 -fprofile-use -fprofile-correction pr111559.c -o b -fopt-info

        pr111559.c: In function 'rule1':
        pr111559.c:6:13: error: probability of edge 3->4 not initialized
            6 | static void rule1(void) { if (p) edge(); }
              |             ^~~~~
        during GIMPLE pass: fixup_cfg
        pr111559.c:6:13: internal compiler error: verify_flow_info failed

    The change conservatively ignores updates with zero execution counts and
    uses initially assigned probabilities (`always` probability in case of
    the example).

            PR ipa/111283
            PR gcov-profile/111559

    gcc/
            * ipa-utils.cc (ipa_merge_profiles): Avoid producing
            uninitialized probabilities when merging counters with zero
            denominators.

    gcc/testsuite/
            * gcc.dg/tree-prof/pr111559.c: New test.

  parent reply	other threads:[~2023-10-05 16:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04  6:11 [Bug ada/111283] New: gnat bootstrap " doko at gcc dot gnu.org
2023-09-04  6:14 ` [Bug ada/111283] " doko at gcc dot gnu.org
2023-09-04  6:18 ` [Bug ipa/111283] [14 Regression] " pinskia at gcc dot gnu.org
2023-09-04  6:19 ` pinskia at gcc dot gnu.org
2023-09-04  6:20 ` [Bug ipa/111283] [14 Regression] gnat profilebootstrap " pinskia at gcc dot gnu.org
2023-09-04  7:55 ` schwab@linux-m68k.org
2023-09-04 11:02 ` doko at gcc dot gnu.org
2023-09-04 11:04 ` doko at gcc dot gnu.org
2023-09-14 10:22 ` sirl at gcc dot gnu.org
2023-09-14 10:24 ` sirl at gcc dot gnu.org
2023-09-27 14:47 ` slyfox at gcc dot gnu.org
2023-10-05 16:14 ` cvs-commit at gcc dot gnu.org [this message]
2023-10-05 16:23 ` slyfox at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111283-4-Jzeq18RFBl@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).