public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/111284] [11/12/13/14 Regression] Some passing-by-value parameters are mishandled since GCC 9
Date: Mon, 11 Sep 2023 11:32:29 +0000	[thread overview]
Message-ID: <bug-111284-4-uNXJ2LgXf9@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111284-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111284

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Actually, the binding of parms seems to work fine.
But am out of ideas where this should be fixed.  When evaluating the
comparison, we have lhs
(const struct S *) (struct S *) ((const struct S *) this)->s
and rhs
(const struct S *) this
and we constant evaluate both.  In both cases we find this (foo's artificial
argument in #c2) is &x where x is bar's PARM_DECL.  But in the lhs case, -> is
applied to it,
so x is evaluated as prvalue as {.s=&D.2836} where D.2836 is the local temp
built for AGGR_INIT_EXPR - but nothing during the constexpr evaluation actually
knows that &D.2836 is actually the address of the x argument.  So, lhs folds
into &D.2836 with some cast.
While then constexpr evaluating rhs sees just accessing this which is &x and in
that case x is used as an lvalue, so the folds into &x.  And those two are not
equal.
So, I think we need to treat somewhere the arguments (and return values?) with
TREE_ADDRESSABLE types during constexpr evaluations actually as references
rather than what they are in the source (so what we do after genericization).

  parent reply	other threads:[~2023-09-11 11:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04 11:16 [Bug c++/111284] New: Some passing-by-value parameters are miscompiled " de34 at live dot cn
2023-09-05 14:37 ` [Bug c++/111284] [11/12/13/14 Regression] Some passing-by-value parameters are mishandled " mpolacek at gcc dot gnu.org
2023-09-05 14:37 ` mpolacek at gcc dot gnu.org
2023-09-05 18:00 ` jakub at gcc dot gnu.org
2023-09-05 18:04 ` jakub at gcc dot gnu.org
2023-09-05 19:21 ` jakub at gcc dot gnu.org
2023-09-05 19:27 ` jakub at gcc dot gnu.org
2023-09-11 11:32 ` jakub at gcc dot gnu.org [this message]
2023-09-11 12:12 ` jakub at gcc dot gnu.org
2024-03-07 18:58 ` [Bug c++/111284] [11/12/13/14 Regression] Some passing-by-value parameters are mishandled since GCC 9, affecting libstdc++'s constexpr std::string jakub at gcc dot gnu.org
2024-03-11 15:12 ` ppalka at gcc dot gnu.org
2024-04-25 18:46 ` cvs-commit at gcc dot gnu.org
2024-04-25 18:48 ` [Bug c++/111284] [11/12/13 " jakub at gcc dot gnu.org
2024-05-09  4:26 ` cvs-commit at gcc dot gnu.org
2024-05-09  8:17 ` [Bug c++/111284] [11/12 " jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111284-4-uNXJ2LgXf9@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).