public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug testsuite/111298] New: time-profiler-2.c flaky on glibc RISC-V @ 2023-09-05 21:25 patrick at rivosinc dot com 2023-09-05 21:30 ` [Bug testsuite/111298] " pinskia at gcc dot gnu.org ` (3 more replies) 0 siblings, 4 replies; 5+ messages in thread From: patrick at rivosinc dot com @ 2023-09-05 21:25 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111298 Bug ID: 111298 Summary: time-profiler-2.c flaky on glibc RISC-V Product: gcc Version: 14.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: testsuite Assignee: unassigned at gcc dot gnu.org Reporter: patrick at rivosinc dot com Target Milestone: --- Created attachment 55845 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55845&action=edit Excerpt from the debug log Failures: FAIL: gcc.dg/tree-prof/time-profiler-2.c scan-ipa-dump-times profile "Read tp_first_run: 0" 2 FAIL: gcc.dg/tree-prof/time-profiler-2.c scan-ipa-dump-times profile "Read tp_first_run: 2" 1 FAIL: gcc.dg/tree-prof/time-profiler-2.c scan-ipa-dump-times profile "Read tp_first_run: 3" 1 Observed on at least one of the 7 tested glibc targets ~50/78 times (~65%). Separated out this gives a ~14% chance that a given testsuite run fails. Example where failures change when comparing across a daily-bump commit: https://github.com/patrick-rivos/riscv-gnu-toolchain/issues/290 Observed on all tested targets: rv32gcv-ilp32d rv32gc_zba_zbb_zbc_zbs-ilp32d rv32gcv_zicond_zawrs_zbc_zvkng_zvksg_zvbb_zvbc_zicsr_zba_zbb_zbs_zicbom_zicbop_zicboz_zfhmin_zkt-ilp32d rv64gc-lp64d rv64gcv-lp64d rv64gc_zba_zbb_zbc_zbs-lp64d rv64gcv_zvbb_zvbc_zvkg_zvkn_zvknc_zvkned_zvkng_zvknha_zvknhb_zvks_zvksc_zvksed_zvksg_zvksh_zvkt-lp64d Not observed using when using newlib. Replicated locally using https://github.com/patrick-rivos/riscv-gnu-toolchain/tree/6feacbc3d00a11a94f1f8fdc7226b4b908462579 ../configure --prefix=$(pwd) --with-arch=rv64gcv --with-abi=lp64 make report-linux -j32 Upstream riscv-gnu-toolchain has the test allowlisted which is likely why nobody has mentioned it before: https://github.com/riscv-collab/riscv-gnu-toolchain/blob/master/test/allowlist/gcc/glibc.log#L8-L10 From searching the https://gcc.gnu.org/pipermail/gcc-testresults/ mailing list (May 1st - September 5th), the only other occurrence is https://inbox.sourceware.org/gcc-testresults/87zg23qmwp.fsf@Rainer.invalid/ This is likely specific to the risc-v target. I'm guessing that this is likely due to some conflict between time-profiler-1.c and time-profiler-2.c and filing this under testsuite framework issue, but feel free to move it if it's likely caused by a specific component. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug testsuite/111298] time-profiler-2.c flaky on glibc RISC-V 2023-09-05 21:25 [Bug testsuite/111298] New: time-profiler-2.c flaky on glibc RISC-V patrick at rivosinc dot com @ 2023-09-05 21:30 ` pinskia at gcc dot gnu.org 2023-09-05 21:54 ` patrick at rivosinc dot com ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: pinskia at gcc dot gnu.org @ 2023-09-05 21:30 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111298 --- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> --- Are you testing using qemu-user? If so it has always been flaky: https://gcc.gnu.org/pipermail/gcc-patches/2013-November/377091.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug testsuite/111298] time-profiler-2.c flaky on glibc RISC-V 2023-09-05 21:25 [Bug testsuite/111298] New: time-profiler-2.c flaky on glibc RISC-V patrick at rivosinc dot com 2023-09-05 21:30 ` [Bug testsuite/111298] " pinskia at gcc dot gnu.org @ 2023-09-05 21:54 ` patrick at rivosinc dot com 2023-11-08 14:47 ` amylaar at gcc dot gnu.org 2023-11-27 17:35 ` [Bug testsuite/111298] time-profiler-2.c flaky on glibc RISC-V with qemu pinskia at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: patrick at rivosinc dot com @ 2023-09-05 21:54 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111298 --- Comment #2 from Patrick O'Neill <patrick at rivosinc dot com> --- Yep I'm using qemu-user, thanks for the link. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug testsuite/111298] time-profiler-2.c flaky on glibc RISC-V 2023-09-05 21:25 [Bug testsuite/111298] New: time-profiler-2.c flaky on glibc RISC-V patrick at rivosinc dot com 2023-09-05 21:30 ` [Bug testsuite/111298] " pinskia at gcc dot gnu.org 2023-09-05 21:54 ` patrick at rivosinc dot com @ 2023-11-08 14:47 ` amylaar at gcc dot gnu.org 2023-11-27 17:35 ` [Bug testsuite/111298] time-profiler-2.c flaky on glibc RISC-V with qemu pinskia at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: amylaar at gcc dot gnu.org @ 2023-11-08 14:47 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111298 Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amylaar at gcc dot gnu.org --- Comment #3 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> --- (In reply to Patrick O'Neill from comment #0) > I'm guessing that this is likely due to some conflict between > time-profiler-1.c and time-profiler-2.c and filing this under testsuite > framework issue, but feel free to move it if it's likely caused by a > specific component. My guess is that the atomic fetch-and-update emitted by gimple_gen_time_profiler is not actually atomic (at least under RISC-V Qemu). Note that in time-profiler-2.c, there is a parent and a child process that access the same gcov data. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug testsuite/111298] time-profiler-2.c flaky on glibc RISC-V with qemu 2023-09-05 21:25 [Bug testsuite/111298] New: time-profiler-2.c flaky on glibc RISC-V patrick at rivosinc dot com ` (2 preceding siblings ...) 2023-11-08 14:47 ` amylaar at gcc dot gnu.org @ 2023-11-27 17:35 ` pinskia at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: pinskia at gcc dot gnu.org @ 2023-11-27 17:35 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111298 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Target|riscv |riscv aarch64 Last reconfirmed| |2023-11-27 --- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> --- Confirm, I see this also on aarch64. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-11-27 17:35 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-09-05 21:25 [Bug testsuite/111298] New: time-profiler-2.c flaky on glibc RISC-V patrick at rivosinc dot com 2023-09-05 21:30 ` [Bug testsuite/111298] " pinskia at gcc dot gnu.org 2023-09-05 21:54 ` patrick at rivosinc dot com 2023-11-08 14:47 ` amylaar at gcc dot gnu.org 2023-11-27 17:35 ` [Bug testsuite/111298] time-profiler-2.c flaky on glibc RISC-V with qemu pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).