From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id D4F003858422; Wed, 13 Sep 2023 01:32:07 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D4F003858422
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1694568727;
	bh=VIqkh+E4OBTi8sSxzAlY9dzkOAx4yYj1r5kxDJ+nB7g=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=g9MXPOSrq4pdxCNqL5piqr9C/znjjjH1CrhyoAc77fJy2KhIP/KOb/LFMcxPuXcdd
	 AWHFJR6n+Y7NgtfQk2cWn1vXwbLGBXnj4eLBMzS6kKTEzLi+K+uF4JEP6O484mEiDL
	 Mg5ckYaNSRcdJNk7+8hXTS21PNNWeC0a++pUUD4A=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/111303] [14 Regression] ICE: in type, at
 value-range.h:869
Date: Wed, 13 Sep 2023 01:32:06 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: guojiufu at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-111303-4-IDmxz654r5@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-111303-4@http.gcc.gnu.org/bugzilla/>
References: <bug-111303-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D111303

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jiu Fu Guo <guojiufu@gcc.gnu.org>:

https://gcc.gnu.org/g:8d8bc560b6ab7f3153db23ffb37157528e5b2c9a

commit r14-3913-g8d8bc560b6ab7f3153db23ffb37157528e5b2c9a
Author: Jiufu Guo <guojiufu@linux.ibm.com>
Date:   Wed Sep 6 21:38:11 2023 +0800

    Checking undefined_p before using the vr

    For pattern "(X + C) / N": "div (plus@3 @0 INTEGER_CST@1) INTEGER_CST@2=
)",
    Even if "X" has value-range and "X + C" does not overflow, "@3" may sti=
ll
    be undefined. Like below example:

    _3 =3D _2 + -5;
    if (0 !=3D 0)
      goto <bb 3>; [34.00%]
    else
      goto <bb 4>; [66.00%]
    ;;  succ:       3
    ;;              4

    ;; basic block 3, loop depth 0
    ;;  pred:       2
    _5 =3D _3 / 5;
    ;;  succ:       4

    The whole pattern "(_2 + -5 ) / 5" is in "bb 3", but "bb 3" would be
    unreachable (because "if (0 !=3D 0)" is always false).
    And "get_range_query (cfun)->range_of_expr (vr3, @3)" is checked in
    "bb 3", "range_of_expr" gets an "undefined vr3". Where "@3" is "_5".

    So, before using "vr3", it would be safe to check "!vr3.undefined_p ()".

            PR tree-optimization/111303

    gcc/ChangeLog:

            * match.pd ((X - N * M) / N): Add undefined_p checking.
            ((X + N * M) / N): Likewise.
            ((X + C) div_rshift N): Likewise.

    gcc/testsuite/ChangeLog:

            * gcc.dg/pr111303.c: New test.=