From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 57AA53858402; Sun, 10 Sep 2023 15:48:11 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 57AA53858402
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1694360891;
	bh=GUtu4F/DwLyTRuaUGegtKY82NJLtYnzDlXTwCpWzIyo=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=v41uzGlo3rNSWc6VDbhwHjksCZ7EsxSYxZhX1CoZEjtCGpiy6a1vhJUAqlRrD75/X
	 JNvxlCsk8pMoHA3v0+5nBoqED5QBvJIHoabnd58MYatV9uA9BQvoA4sPurTY7YvnuH
	 66kN0By7I9VVvrKgyCLcBJPI9O2wykK4KATR/tKc=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/111331] [11/12/13/14 Regression] Wrong code
 at -O1 on x86_64-linux-gnu since
Date: Sun, 10 Sep 2023 15:48:10 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: patch, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: pinskia at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 11.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-111331-4-5xHcpvvE5l@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-111331-4@http.gcc.gnu.org/bugzilla/>
References: <bug-111331-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D111331

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:30e6ee074588bacefd2dfe745b188bb20c81fe5e

commit r14-3827-g30e6ee074588bacefd2dfe745b188bb20c81fe5e
Author: Andrew Pinski <apinski@marvell.com>
Date:   Thu Sep 7 22:13:31 2023 -0700

    Fix PR 111331: wrong code for `a > 28 ? MIN<a, 28> : 29`

    The problem here is after r6-7425-ga9fee7cdc3c62d0e51730,
    the comparison to see if the transformation could be done was using the
    wrong value. Instead of see if the inner was LE (for MIN and GE for MAX)
    the outer value, it was comparing the inner to the value used in the
comparison
    which was wrong.
    The match pattern copied the same logic mistake when they were added in
    r14-1411-g17cca3c43e2f49 .

    OK? Bootstrapped and tested on x86_64-linux-gnu.

    gcc/ChangeLog:

            PR tree-optimization/111331
            * match.pd (`(a CMP CST1) ? max<a,CST2> : a`):
            Fix the LE/GE comparison to the correct value.
            * tree-ssa-phiopt.cc (minmax_replacement):
            Fix the LE/GE comparison for the
            `(a CMP CST1) ? max<a,CST2> : a` optimization.

    gcc/testsuite/ChangeLog:

            PR tree-optimization/111331
            * gcc.c-torture/execute/pr111331-1.c: New test.
            * gcc.c-torture/execute/pr111331-2.c: New test.
            * gcc.c-torture/execute/pr111331-3.c: New test.=