public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "xry111 at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/111334] ICE is reported during the combine pass optimization
Date: Fri, 08 Sep 2023 04:45:53 +0000	[thread overview]
Message-ID: <bug-111334-4-gf68OO8VmB@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111334-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111334

--- Comment #6 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
(In reply to Xi Ruoyao from comment #5)
> (In reply to chenglulu from comment #3)
> > This involves the template <optab>di3_fake:
> > (define_insn "<optab>di3_fake"
> >   [(set (match_operand:DI 0 "register_operand" "=r,&r,&r")
> >         (sign_extend:DI
> >           (any_div:SI (match_operand:DI 1 "register_operand" "r,r,0")
> >                       (match_operand:DI 2 "register_operand" "r,r,r"))))]
> >   ""
> > {
> >   return loongarch_output_division ("<insn>.w<u>\t%0,%1,%2", operands);
> > }
> >   [(set_attr "type" "idiv")
> >    (set_attr "mode" "SI")
> >    (set (attr "enabled")
> >       (if_then_else
> >         (match_test "!!which_alternative == loongarch_check_zero_div_p()")
> >         (const_string "yes")
> >         (const_string "no")))])
> > 
> > 
> > I think there is a problem with the implementation of this template. 
> > First, the instructions generated in the template are [u]div.w[u], etc. The
> > description of such instructions in the instruction manual is that if the
> > upper 32 bits are not extended by the 31st bit sign then the result is
> > uncertain.
> 
> I think this reason alone makes the pattern looks very wrong.
> 
> I'll take a look...

Hmm, I guess we should just make di3_fake an UNSPEC because there is no way to
use div.w and its friends out of <optab:any_div><mode>3.

  parent reply	other threads:[~2023-09-08  4:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-08  3:17 [Bug c/111334] New: " chenglulu at loongson dot cn
2023-09-08  3:20 ` [Bug c/111334] " chenglulu at loongson dot cn
2023-09-08  3:26 ` chenglulu at loongson dot cn
2023-09-08  3:52 ` chenglulu at loongson dot cn
2023-09-08  3:58 ` [Bug target/111334] " pinskia at gcc dot gnu.org
2023-09-08  4:39 ` xry111 at gcc dot gnu.org
2023-09-08  4:45 ` xry111 at gcc dot gnu.org [this message]
2023-09-08  4:48 ` [Bug target/111334] [14 regression] " xry111 at gcc dot gnu.org
2023-09-08  6:02 ` chenglulu at loongson dot cn
2023-09-08  6:18 ` chenglulu at loongson dot cn
2023-09-08  6:39 ` xry111 at gcc dot gnu.org
2023-09-08  6:47 ` xry111 at gcc dot gnu.org
2023-09-08  6:53 ` chenglulu at loongson dot cn
2023-09-08  6:58 ` xry111 at gcc dot gnu.org
2023-09-08  7:03 ` chenglulu at loongson dot cn
2023-09-08  7:04 ` xry111 at gcc dot gnu.org
2023-09-08  7:16 ` xry111 at gcc dot gnu.org
2023-09-09  7:16 ` chenglulu at loongson dot cn
2023-09-09  7:47 ` xry111 at gcc dot gnu.org
2023-09-09  8:24 ` chenglulu at loongson dot cn
2023-09-09  9:52 ` xry111 at gcc dot gnu.org
2023-09-14  1:06 ` cvs-commit at gcc dot gnu.org
2023-09-14  1:17 ` chenglulu at loongson dot cn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111334-4-gf68OO8VmB@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).