public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/111404] [AArch64] 128-bit __sync_val_compare_and_swap is not atomic
Date: Thu, 30 Nov 2023 16:45:01 +0000	[thread overview]
Message-ID: <bug-111404-4-X7vDzLAQ0s@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111404-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111404

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Wilco Dijkstra <wilco@gcc.gnu.org>:

https://gcc.gnu.org/g:df8958e6bc5d050dab8bdc5954c1632fb0e98d18

commit r14-6021-gdf8958e6bc5d050dab8bdc5954c1632fb0e98d18
Author: Wilco Dijkstra <wilco.dijkstra@arm.com>
Date:   Thu Nov 30 16:14:35 2023 +0000

    AArch64: Fix __sync_val_compare_and_swap [PR111404]

    __sync_val_compare_and_swap may be used on 128-bit types and either calls
the
    outline atomic code or uses an inline loop.  On AArch64 LDXP is only atomic
if
    the value is stored successfully using STXP, but the current
implementations
    do not perform the store if the comparison fails.  In this case the value
    returned is not read atomically.

    gcc/ChangeLog:
            PR target/111404
            * config/aarch64/aarch64.cc (aarch64_split_compare_and_swap):
            For 128-bit store the loaded value and loop if needed.

    libgcc/ChangeLog:
            PR target/111404
            * config/aarch64/lse.S (__aarch64_cas16_acq_rel): Execute STLXP
using
            either new value or loaded value.

      parent reply	other threads:[~2023-11-30 16:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 14:45 [Bug target/111404] New: " wilco at gcc dot gnu.org
2023-09-14 17:13 ` [Bug target/111404] " wilco at gcc dot gnu.org
2023-11-30 16:45 ` cvs-commit at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111404-4-X7vDzLAQ0s@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).