public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/111411] [14 regression] ICE when building opus-1.4, unrecognizable insn with -fstack-protector-strong
Date: Wed, 20 Sep 2023 10:13:40 +0000	[thread overview]
Message-ID: <bug-111411-4-TnOmx6kyEh@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111411-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111411

--- Comment #14 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Richard Sandiford
<rsandifo@gcc.gnu.org>:

https://gcc.gnu.org/g:74f99f1adc696f446115f36974a3f94f66294a53

commit r12-9886-g74f99f1adc696f446115f36974a3f94f66294a53
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Wed Sep 20 11:13:20 2023 +0100

    aarch64: Fix loose ldpstp check [PR111411]

    aarch64_operands_ok_for_ldpstp contained the code:

      /* One of the memory accesses must be a mempair operand.
         If it is not the first one, they need to be swapped by the
         peephole.  */
      if (!aarch64_mem_pair_operand (mem_1, GET_MODE (mem_1))
           && !aarch64_mem_pair_operand (mem_2, GET_MODE (mem_2)))
        return false;

    But the requirement isn't just that one of the accesses must be a
    valid mempair operand.  It's that the lower access must be, since
    that's the access that will be used for the instruction operand.

    gcc/
            PR target/111411
            * config/aarch64/aarch64.cc (aarch64_operands_ok_for_ldpstp):
Require
            the lower memory access to a mem-pair operand.

    gcc/testsuite/
            PR target/111411
            * gcc.dg/rtl/aarch64/pr111411.c: New test.

    (cherry picked from commit 2d38f45bcca62ca0c7afef4b579f82c5c2a01610)

  parent reply	other threads:[~2023-09-20 10:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14  3:07 [Bug target/111411] New: [14 regression] ICE when building opus-1.4 (celt_decoder.c:1182:1: internal compiler error: in extract_insn, at recog.cc:2791) sjames at gcc dot gnu.org
2023-09-14  3:30 ` [Bug target/111411] " pinskia at gcc dot gnu.org
2023-09-14  3:31 ` [Bug target/111411] [14 regression] ICE when building opus-1.4, unrecognizable insn with -fstack-protector-strong pinskia at gcc dot gnu.org
2023-09-14  5:15 ` sjames at gcc dot gnu.org
2023-09-14 14:45 ` pinskia at gcc dot gnu.org
2023-09-14 15:07 ` rsandifo at gcc dot gnu.org
2023-09-14 16:33 ` sjames at gcc dot gnu.org
2023-09-14 17:34 ` rsandifo at gcc dot gnu.org
2023-09-14 18:41 ` rsandifo at gcc dot gnu.org
2023-09-14 18:41 ` rsandifo at gcc dot gnu.org
2023-09-15  8:19 ` cvs-commit at gcc dot gnu.org
2023-09-15  8:22 ` rsandifo at gcc dot gnu.org
2023-09-15  9:28 ` Martin.Jansa at gmail dot com
2023-09-15  9:28 ` Martin.Jansa at gmail dot com
2023-09-20 10:08 ` cvs-commit at gcc dot gnu.org
2023-09-20 10:13 ` cvs-commit at gcc dot gnu.org [this message]
2023-09-20 10:53 ` rsandifo at gcc dot gnu.org
2023-10-05 17:22 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111411-4-TnOmx6kyEh@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).