public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libgomp/111413] libgomp >= 13 segfault on loading if environ is NULL Date: Tue, 19 Sep 2023 07:31:06 +0000 [thread overview] Message-ID: <bug-111413-4-zrGckDSDZ2@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-111413-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111413 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:15345980633c502f0486a2e40e96224f49134130 commit r14-4122-g15345980633c502f0486a2e40e96224f49134130 Author: Jakub Jelinek <jakub@redhat.com> Date: Tue Sep 19 09:26:35 2023 +0200 libgomp: Handle NULL environ like pointer to NULL pointer [PR111413] clearenv function just sets environ to NULL (after sometimes freeing it), rather than setting it to a pointer to NULL, and our code was assuming it is always non-NULL. Fixed thusly, the change seems to be large but actually is just + if (environ) for (env = environ; *env != 0; env++) plus reindentation. I've also noticed the block after this for loop was badly indented (too much) and fixed that too. No testcase added, as it needs clearenv + dlopen. 2023-09-19 Jakub Jelinek <jakub@redhat.com> PR libgomp/111413 * env.c (initialize_env): Don't dereference environ if it is NULL. Reindent.
next prev parent reply other threads:[~2023-09-19 7:31 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-14 10:09 [Bug libgomp/111413] New: " silvio at traversaro dot it 2023-09-18 9:03 ` [Bug libgomp/111413] " jakub at gcc dot gnu.org 2023-09-19 7:31 ` cvs-commit at gcc dot gnu.org [this message] 2023-09-19 8:31 ` silvio at traversaro dot it 2023-12-05 16:32 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-111413-4-zrGckDSDZ2@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).