From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id BFF653858D28; Sun, 17 Sep 2023 06:47:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BFF653858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1694933239; bh=fmqBD7DiW0YWdggd5OYj2XZNPTrDE004PCW8a43GuwI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=FJoROQtssPY1ODMfiHt1ARaWIU9UxPUaMznoD4NoF0MsoxedOj6Mh+sshZCCfX77V N/3VaXrQKP2X4pkY1CiCeJRS+TEbn70GAvezUKTx+ApI3CxhKsiNe4RsbiuMqV0mlE KEsx6Dcobvq8mPb2MXWFfC9dOXKU3dmz8KalkaZQ= From: "gb2985 at gmail dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/111437] Some always inline functions are incorrectly warn of as "might not be inlinable" Date: Sun, 17 Sep 2023 06:47:19 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: ipa X-Bugzilla-Version: 13.2.1 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: gb2985 at gmail dot com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D111437 zxuiji changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |FIXED --- Comment #5 from zxuiji --- (In reply to Andrew Pinski from comment #4) > One definition has: > __attribute__((hot)) __attribute__((always_inline)) pawd pawmsg_SIGKILL( > pawexe pid ) > { return pawtrigger(=20 > # 127 "/mnt/CODE/gitlab/dragonbuilder/include/paw/pawint/../pawmsg.h" 3 4 > ((void *)0) > # 127 "/mnt/CODE/gitlab/dragonbuilder/include/paw/pawint/../pawmsg.h" > , PAWMSGID_KILL_NOW, PAWMSG_CLSID_APP, 0, pid );= } >=20 > Yes without inline the always_inline might be not be inlinable ... >=20 > The preprocessed source is full of issues; redefinitions: > /mnt/CODE/gitlab/dragonbuilder/src/libpaw/pawaio.c:50:28: error: > redefinition of =E2=80=98pawabspath_putroot=E2=80=99 > In file included from /mnt/CODE/gitlab/dragonbuilder/src/libpaw/libpaw.h:= 19, > from /mnt/CODE/gitlab/dragonbuilder/src/libpaw/pawaio.c:= 1: > /mnt/CODE/gitlab/dragonbuilder/include/paw/pawaio.h:554:28: note: previous > definition of =E2=80=98pawabspath_putroot=E2=80=99 with type =E2=80=98paw= jd(pawmbcd *, pawmbctxt,=20 > pawmbctxt)=E2=80=99 {aka =E2=80=98long int(pawmbcd *, pawmbc_txt, pawmbc= _txt)=E2=80=99} >=20 >=20 > etc. >=20 > But the pattern for the "might not be inlinable" is all the same as what I > mentioned first. There is only always_inline without an inline ... You mean I should add __inline to the definition of PAWANT_QCK so it follows the always_inline attribute? Well that's easy enough however that does beg = the question, why is inline not implicit with the always_inline attribute? That aside, yeah I'm aware there are issues with the code itself, in the middle = of a redesign and using the compiler to identify where the surface level issues = are, I'll get on the runtime ones after I finish putting together the library and the unit tests thereafter.=