public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/111485] [11/12/13/14 Regression] Constraint mismatch on template template parameter
Date: Sun, 24 Sep 2023 18:42:50 +0000	[thread overview]
Message-ID: <bug-111485-4-DevpgbjwYb@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111485-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111485

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:59f5786c20a42be13ac6fec567ffe840045012ad

commit r13-7836-g59f5786c20a42be13ac6fec567ffe840045012ad
Author: Patrick Palka <ppalka@redhat.com>
Date:   Fri Sep 22 06:25:49 2023 -0400

    c++: constraint rewriting during ttp coercion [PR111485]

    In order to compare the constraints of a ttp with that of its argument,
    we rewrite the ttp's constraints in terms of the argument template's
    template parameters.  The substitution to achieve this currently uses a
    single level of template arguments, but that never does the right thing
    because a ttp's template parameters always have level >= 2.  This patch
    fixes this by including the outer template arguments in the substitution,
    which ought to match the depth of the ttp.

    The second testcase demonstrates it's better to substitute the concrete
    outer template arguments instead of generic ones since a ttp's constraints
    could depend on outer parameters.

            PR c++/111485

    gcc/cp/ChangeLog:

            * pt.cc (is_compatible_template_arg): New parameter 'args'.
            Add the outer template arguments 'args' to 'new_args'.
            (convert_template_argument): Pass 'args' to
            is_compatible_template_arg.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp2a/concepts-ttp5.C: New test.
            * g++.dg/cpp2a/concepts-ttp6.C: New test.

    (cherry picked from commit 6f902a42b0afe3f3145bcb864695fc290b5acc3e)

  parent reply	other threads:[~2023-09-24 18:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19 16:50 [Bug c++/111485] New: " barry.revzin at gmail dot com
2023-09-19 17:29 ` [Bug c++/111485] [11/12/13/14 Regression] " ppalka at gcc dot gnu.org
2023-09-22 10:26 ` cvs-commit at gcc dot gnu.org
2023-09-24 18:42 ` cvs-commit at gcc dot gnu.org [this message]
2023-12-24 15:11 ` [Bug c++/111485] [11/12 " cvs-commit at gcc dot gnu.org
2023-12-24 15:12 ` cvs-commit at gcc dot gnu.org
2024-01-02 17:59 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111485-4-DevpgbjwYb@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).