public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/111519] [13/14 Regression] Wrong code at -O3 on x86_64-linux-gnu since r13-455-g1fe04c497d Date: Wed, 11 Oct 2023 07:09:35 +0000 [thread overview] Message-ID: <bug-111519-4-ImaOYiMhi9@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-111519-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111519 --- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:e75bf1985fdc9a5d3a307882a9251d8fd6e93def commit r14-4552-ge75bf1985fdc9a5d3a307882a9251d8fd6e93def Author: Jakub Jelinek <jakub@redhat.com> Date: Wed Oct 11 08:58:29 2023 +0200 tree-ssa-strlen: optimization skips clobbering store [PR111519] The following testcase is miscompiled, because count_nonzero_bytes incorrectly uses get_strinfo information on a pointer from which an earlier instruction loads SSA_NAME stored at the current instruction. get_strinfo shows a state right before the current store though, so if there are some stores in between the current store and the load, the string length information might have changed. The patch passes around gimple_vuse from the store and punts instead of using strinfo on loads from MEM_REF which have different gimple_vuse from that. 2023-10-11 Richard Biener <rguenther@suse.de> Jakub Jelinek <jakub@redhat.com> PR tree-optimization/111519 * tree-ssa-strlen.cc (strlen_pass::count_nonzero_bytes): Add vuse argument and pass it through to recursive calls and count_nonzero_bytes_addr calls. Don't shadow the stmt argument, but change stmt for gimple_assign_single_p statements for which we don't immediately punt. (strlen_pass::count_nonzero_bytes_addr): Add vuse argument and pass it through to recursive calls and count_nonzero_bytes calls. Don't use get_strinfo if gimple_vuse (stmt) is different from vuse. Don't shadow the stmt argument. * gcc.dg/torture/pr111519.c: New testcase.
next prev parent reply other threads:[~2023-10-11 7:09 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-21 13:20 [Bug tree-optimization/111519] New: " shaohua.li at inf dot ethz.ch 2023-09-21 15:35 ` [Bug tree-optimization/111519] " pinskia at gcc dot gnu.org 2023-09-21 15:47 ` pinskia at gcc dot gnu.org 2023-09-21 16:00 ` rguenth at gcc dot gnu.org 2023-10-09 22:05 ` roger at nextmovesoftware dot com 2023-10-10 7:56 ` rguenth at gcc dot gnu.org 2023-10-10 8:21 ` jakub at gcc dot gnu.org 2023-10-10 8:26 ` rguenth at gcc dot gnu.org 2023-10-10 8:31 ` rguenth at gcc dot gnu.org 2023-10-10 8:33 ` rguenth at gcc dot gnu.org 2023-10-10 10:37 ` rguenth at gcc dot gnu.org 2023-10-11 7:09 ` cvs-commit at gcc dot gnu.org [this message] 2023-10-11 7:23 ` cvs-commit at gcc dot gnu.org 2023-10-11 7:24 ` jakub at gcc dot gnu.org 2023-11-02 9:05 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-111519-4-ImaOYiMhi9@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).