public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/111523] Unexpected performance regression with -ftrivial-auto-var-init=zero for e.g. systemctl unmask
Date: Thu, 07 Mar 2024 06:45:22 +0000	[thread overview]
Message-ID: <bug-111523-4-9qMMcHgXIn@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111523-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111523

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |MOVED

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Turns out systemd had a 1MB buffer in their serializer formating code
(serialize_item_format) that would be executed a lot and
-ftrivial-auto-var-init=zero would cause this buffer to be zero'd each time the
function was called (a decent thing for this flag to do).

It just happens serialize_item_format is called a lot when it came
serialization. With arm memory systems being slower than most, it just exposed
this issue.

Anways systemd has now changed the buffer to 256 which is much much smaller and
for most calls enough in size before needing to reallocate the buffer that it
has now become fast.

Anyways -ftrivial-auto-var-init=zero just exposed a performance (stack size)
issue with already existing issue inside the systemd code. A good thing really. 

So closing as moved.

  parent reply	other threads:[~2024-03-07  6:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21 16:40 [Bug middle-end/111523] New: " hp at gcc dot gnu.org
2023-09-21 16:49 ` [Bug middle-end/111523] " sjames at gcc dot gnu.org
2024-02-29 19:19 ` qinzhao at gcc dot gnu.org
2024-03-01  0:12 ` sjames at gcc dot gnu.org
2024-03-01  1:25 ` pinskia at gcc dot gnu.org
2024-03-01  5:15 ` pinskia at gcc dot gnu.org
2024-03-01  7:57 ` pinskia at gcc dot gnu.org
2024-03-01  8:23 ` pinskia at gcc dot gnu.org
2024-03-01  8:38 ` pinskia at gcc dot gnu.org
2024-03-07  6:45 ` pinskia at gcc dot gnu.org [this message]
2024-03-13 14:01 ` qinzhao at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111523-4-9qMMcHgXIn@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).